Remove MaterialFontsOverride.xaml #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
reviewed
Oct 3, 2023
src/Uno.Templates/content/unoapp/.template.config/template.json
Outdated
Show resolved
Hide resolved
nickrandolph
approved these changes
Oct 3, 2023
nickrandolph
approved these changes
Oct 4, 2023
dansiegel
force-pushed
the
dev/ds/font-overrides
branch
2 times, most recently
from
45184c3 to
b4336ce
Compare
Youssef1313
reviewed
Oct 10, 2023
dansiegel
force-pushed
the
dev/ds/font-overrides
branch
3 times, most recently
from
28d071f to
44e627c
Compare
nickrandolph
force-pushed
the
dev/ds/font-overrides
branch
from
44e627c to
6cdc909
Compare
dansiegel
force-pushed
the
dev/ds/font-overrides
branch
2 times, most recently
from
8fc44a4 to
b873c2e
Compare
dansiegel
force-pushed
the
dev/ds/font-overrides
branch
from
b873c2e to
6ebfd58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Font Overrides use default Roboto Fonts that aren't actually needed anymore.
What is the new behavior?
FontOverrides.xaml has been removed. We now show developers how to override in a commented out ResourceDictionary added directly to the FontOverrideDictionary property of the MaterialTheme or MaterialToolkitTheme