feat: Add flag to enable analyzers

src/Uno.Templates/content/unoapp/.globalconfig

@@ -0,0 +1,4 @@
+is_global = true
+
+# IDE0055: Fix formatting
+dotnet_diagnostic.IDE0055.severity = warning

src/Uno.Templates/content/unoapp/.template.config/dotnetcli.host.json

@@ -53,6 +53,10 @@
       "longName": "dependency-injection",
       "shortName": "di"
     },
+    "analyzers": {
+      "longName": "analyzers",
+      "shortName": "analyzers"
+    },
     "configuration": {
       "longName": "configuration",
       "shortName": "config"

src/Uno.Templates/content/unoapp/.template.config/template.json

@@ -406,6 +406,13 @@
       "type": "parameter",
       "datatype": "bool"
     },
+    "analyzers": {
+      "displayName": "Analyzers",
+      "description": "Enable C# analyzers",
+      "type": "parameter",
+      "datatype": "bool",
+      "defaultValue": "true"
+    },
     "configuration": {
       "displayName": "Configuration",
       "description": "Load configuration information from appsettings.json",

src/Uno.Templates/content/unoapp/Directory.Build.props

@@ -52,6 +52,17 @@
     <AndroidMaterialVersion  Condition=" '$(AndroidMaterialVersion)' == '' ">1.9.0.2</AndroidMaterialVersion>
     <AndroidXNavigationVersion  Condition=" '$(AndroidXNavigationVersion)' == '' ">2.6.0.1</AndroidXNavigationVersion>
     <!--#endif-->
+    <!--#if (analyzers)-->
+
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <AnalysisMode>Recommended</AnalysisMode>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+
+    <!-- CA1010: Type 'MainPage' directly or indirectly inherits 'IEnumerable' without implementing 'IEnumerable<T>' -->
+    <!-- CA1848: For improved performance, use the LoggerMessage delegates -->
+    <NoWarn>$(NoWarn);CA1010;CA1848</NoWarn>
+    <!--#endif-->
   </PropertyGroup>
 
   <Choose>

src/Uno.Templates/content/unoapp/MyExtensionsApp._1.MauiControls/EmbeddedControl.xaml.cs

@@ -10,7 +10,7 @@ public EmbeddedControl()
 
 //+:cnd:noEmit
 #if (!useMvvmOrMvux)
-    private int count=0;
+    private int count;
     public void CounterClicked(object sender, EventArgs e)
     {
         CounterButton.Text = ++count switch

src/Uno.Templates/content/unoapp/MyExtensionsApp._1.MauiControls/UnoImageConverter.cs

@@ -5,16 +5,16 @@ namespace MyExtensionsApp._1;
 
 public class UnoImageConverter : IValueConverter
 {
-    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
 #if ANDROID
-        return (value + "").Replace('/','_').Replace('\\','_');
+        return (value + "").Replace('/', '_').Replace('\\', '_');
 #else
         return value;
 #endif
     }
 
-    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    public object? ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         throw new NotImplementedException();
     }

src/Uno.Templates/content/unoapp/MyExtensionsApp._1.Server/Apis/WeatherForecastApi.cs

@@ -41,7 +41,6 @@ private static IEnumerable<WeatherForecast> GetForecast(ILoggerFactory loggerFac
         {
             logger.LogInformation("Weather forecast for {Date} is a {Summary} {TemperatureC}°C", x.Date, x.Summary, x.TemperatureC);
             return x;
-        })
-        .ToArray();
+        });
     }
 }

src/Uno.Templates/content/unoapp/MyExtensionsApp._1.Server/Program.cs

@@ -1,4 +1,7 @@
 //+:cnd:noEmit
+#if (useSerilog)
+using System.Globalization;
+#endif
 #if (useHttp)
 using System.Text.Json.Serialization.Metadata;
 #endif
@@ -16,8 +19,8 @@
 {
 #if (useSerilog)
     Log.Logger = new LoggerConfiguration()
-            .WriteTo.Console()
-            .WriteTo.File(Path.Combine("App_Data", "Logs", "log.txt"))
+            .WriteTo.Console(formatProvider: CultureInfo.InvariantCulture)
+            .WriteTo.File(Path.Combine("App_Data", "Logs", "log.txt"), formatProvider: CultureInfo.InvariantCulture)
             .CreateLogger();
 #endif
     var builder = WebApplication.CreateBuilder(args);

src/Uno.Templates/content/unoapp/MyExtensionsApp._1.UITests/MyExtensionsApp._1.UITests.csproj

@@ -2,6 +2,12 @@
 
   <PropertyGroup>
     <TargetFramework>$baseTargetFramework$</TargetFramework>
+    <!--#if (analyzers)-->
+
+    <!-- CA1707: Remove the underscores from type name -->
+    <NoWarn>$(NoWarn);CA1707</NoWarn>
+    <!--#endif-->
+
   </PropertyGroup>
 
   <ItemGroup>

src/Uno.Templates/content/unoapp/MyExtensionsApp._1/App.recommended.cs

@@ -1,4 +1,6 @@
 //-:cnd:noEmit
+using System.Globalization;
+
 namespace MyExtensionsApp._1;
 
 //+:cnd:noEmit
@@ -123,7 +125,7 @@ protected async override void OnLaunched(LaunchActivatedEventArgs args)
                         credentials ??= new Dictionary<string, string>();
                         credentials[TokenCacheExtensions.AccessTokenKey] = "SampleToken";
                         credentials[TokenCacheExtensions.RefreshTokenKey] = "RefreshToken";
-                        credentials["Expiry"] = DateTime.Now.AddMinutes(5).ToString("g");
+                        credentials["Expiry"] = DateTime.Now.AddMinutes(5).ToString("g", DateTimeFormatInfo.InvariantInfo);
                         return ValueTask.FromResult<IDictionary<string, string>?>(credentials);
                     }
 
@@ -142,7 +144,7 @@ protected async override void OnLaunched(LaunchActivatedEventArgs args)
                         // Return IDictionary containing any tokens used by service calls or in the app
                         tokenDictionary ??= new Dictionary<string, string>();
                         tokenDictionary[TokenCacheExtensions.AccessTokenKey] = "NewSampleToken";
-                        tokenDictionary["Expiry"] = DateTime.Now.AddMinutes(5).ToString("g");
+                        tokenDictionary["Expiry"] = DateTime.Now.AddMinutes(5).ToString("g", DateTimeFormatInfo.InvariantInfo);
                         return ValueTask.FromResult<IDictionary<string, string>?>(tokenDictionary);
                     }
 

src/Uno.Templates/content/unoapp/MyExtensionsApp._1/AppResources.cs

@@ -14,13 +14,13 @@ public AppResources()
 #if useToolkit
         // Load Uno.UI.Toolkit and Material Resources
         this.Build(r => r.Merged(
-            new  MaterialToolkitTheme(
+            new MaterialToolkitTheme(
                     new Styles.ColorPaletteOverride(),
                     new Styles.MaterialFontsOverride())));
 #else
         // Load Uno.UI.Toolkit and Material Resources
         this.Build(r => r.Merged(
-            new  MaterialTheme(
+            new MaterialTheme(
                     new Styles.ColorPaletteOverride(),
                     new Styles.MaterialFontsOverride())));
 #endif

src/Uno.Templates/content/unoapp/MyExtensionsApp._1/Infrastructure/DebugHandler.cs

@@ -1,7 +1,7 @@
 //+:cnd:noEmit
 namespace MyExtensionsApp._1.Infrastructure;
 
-internal class DebugHttpHandler : DelegatingHandler
+internal sealed class DebugHttpHandler : DelegatingHandler
 {
 #if (useLogging)
     private readonly ILogger _logger;
@@ -34,13 +34,13 @@ protected async override Task<HttpResponseMessage> SendAsync(
             {
                 _logger.LogDebugMessage($"{request.RequestUri} ({request.Method})");
             }
-            
+
             foreach ((var key, var values) in request.Headers.ToDictionary(x => x.Key, x => string.Join(", ", x.Value)))
             {
                 _logger.LogDebugMessage($"{key}: {values}");
             }
 
-            var content = request.Content is not null ? await request.Content.ReadAsStringAsync() : null;
+            var content = request.Content is not null ? await request.Content.ReadAsStringAsync(cancellationToken) : null;
             if (!string.IsNullOrEmpty(content))
             {
                 _logger.LogDebugMessage(content);
@@ -57,7 +57,7 @@ protected async override Task<HttpResponseMessage> SendAsync(
                 Console.Error.WriteLine($"  {key}: {values}");
             }
 
-            var content = request.Content is not null ? await request.Content.ReadAsStringAsync() : null;
+            var content = request.Content is not null ? await request.Content.ReadAsStringAsync(cancellationToken) : null;
             if (!string.IsNullOrEmpty(content))
             {
                 Console.Error.WriteLine(content);

src/Uno.Templates/content/unoapp/MyExtensionsApp._1/Presentation/LoginModel.cs

@@ -7,7 +7,7 @@ public partial record LoginModel(IDispatcher Dispatcher, INavigator Navigator, I
 
  //+:cnd:noEmit
 #if useCustomAuthentication
-   public IState<string> Username => State<string>.Value(this, () => string.Empty);
+    public IState<string> Username => State<string>.Value(this, () => string.Empty);
 
     public IState<string> Password => State<string>.Value(this, () => string.Empty);
 #endif
@@ -25,8 +25,7 @@ public async ValueTask Login(CancellationToken token)
 //-:cnd:noEmit
         if (success)
         {
-            await Navigator.NavigateViewModelAsync<MainModel>(this, qualifier: Qualifiers.ClearBackStack);
+            await Navigator.NavigateViewModelAsync<MainModel>(this, qualifier: Qualifiers.ClearBackStack, cancellation: token);
         }
     }
-
 }

src/Uno.Templates/content/unoapp/MyExtensionsApp._1/Services/Caching/WeatherCache.cs

@@ -23,7 +23,7 @@ public WeatherCache(IApiClient api, ISerializer serializer)
     }
 #endif
 
-    private bool IsConnected => NetworkInformation.GetInternetConnectionProfile().GetNetworkConnectivityLevel() == NetworkConnectivityLevel.InternetAccess;
+    private static bool IsConnected => NetworkInformation.GetInternetConnectionProfile().GetNetworkConnectivityLevel() == NetworkConnectivityLevel.InternetAccess;
 
     public async ValueTask<IImmutableList<WeatherForecast>> GetForecast(CancellationToken token)
     {
@@ -38,7 +38,7 @@ public async ValueTask<IImmutableList<WeatherForecast>> GetForecast(Cancellation
 #if (useLogging)
             _logger.LogWarning("App is offline and cannot connect to the API.");
 #endif
-            throw new Exception("No internet connection");
+            throw new InvalidOperationException("No internet connection");
         }
 
         var response = await _api.GetWeather(token);
@@ -62,10 +62,10 @@ public async ValueTask<IImmutableList<WeatherForecast>> GetForecast(Cancellation
         }
     }
 
-    private async ValueTask<StorageFile> GetFile(CreationCollisionOption option) =>
+    private static async ValueTask<StorageFile> GetFile(CreationCollisionOption option) =>
         await ApplicationData.Current.TemporaryFolder.CreateFileAsync("weather.json", option);
 
-    private async ValueTask<string?> GetCachedWeather()
+    private static async ValueTask<string?> GetCachedWeather()
     {
         var file = await GetFile(CreationCollisionOption.OpenIfExists);
         var properties = await file.GetBasicPropertiesAsync();
@@ -84,6 +84,6 @@ private async ValueTask Save(IImmutableList<WeatherForecast> weather, Cancellati
     {
         var weatherText = _serializer.ToString(weather);
         var file = await GetFile(CreationCollisionOption.ReplaceExisting);
-        await File.WriteAllTextAsync(file.Path, weatherText);
+        await File.WriteAllTextAsync(file.Path, weatherText, token);
     }
 }