Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust launchSettings.json to use a port other than 5000 #360

Merged
merged 6 commits into from
Oct 27, 2023
Merged

fix: Adjust launchSettings.json to use a port other than 5000 #360

merged 6 commits into from
Oct 27, 2023

Conversation

jeromelaban
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

This is a workaround for https://developercommunity.visualstudio.com/t/BrowserLink-WebSocket-is-disconnecting-a/10500228, which can break the hot reload session when the port is specifically 5000 in some machine configurations.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@jeromelaban
fix: Adjust launchSettings.json to use a port other than 5000
01294c6 
This is a workaround for https://developercommunity.visualstudio.com/t/BrowserLink-WebSocket-is-disconnecting-a/10500228, which can break the hot reload session when the port is specifically 5000 in some machine configurations.
nickrandolph
nickrandolph requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@nickrandolph nickrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to adjust the port in the ui tests to match

@dansiegel dansiegel enabled auto-merge October 27, 2023 12:46
@dansiegel dansiegel merged commit c839940 into main Oct 27, 2023
38 checks passed
@dansiegel dansiegel deleted the dev/jela/vs17-8-workaround branch October 27, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

@nickrandolph nickrandolph nickrandolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromelaban @nickrandolph @dansiegel