Workaround for malformed YAML when tests are disabled #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
approved these changes
Nov 20, 2023
|
@Mergifyio backport release/stable/5.0 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When someone creates a template without Unit Tests but with GitHub Actions, the generated YAML is malformed as the template engine removes most but not all of the code block for the Unit Test job.
What is the new behavior?
We now have an empty
#else. The Template Engine seems to now properly box the job for the Unit Tests and include it when the condition is true and exclude it in its entirety when the condition is false.Other information
This is a workaround. Hopefully the .NET Templating team will come up with a better long term fix for this so we can remove the hack of the empty
#else