Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Recommend unoplatform.vscode inside VS Code #480

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

spouliot
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Opening a new solution, based on the templates, inside VS Code does not suggest installing the Uno Platform extension. Instead it suggest installed C# DevKit which does not work with our extension.

What is the new behavior?

This will suggest the installation of the Uno Platform extension (if not already installed) when opening the solution folder inside VS Code.

As the Uno Platform extension depends on the MS C# extension, the latter will also be installed (if not already). Sadly it does not enable the useOmniSharp setting even when C# DevKit is not present :( The Uno Platform logs prints an error and a link to the documentation in this case [1].

This also stop VS Code from recommending C# DevKit (which was done before suggesting Uno) since the Uno extension cannot work yet with it (and the available experimental API could break the integration at any time). We'll recommend C# DevKit when ready on our own terms.

[1] a future version of the Uno Platform extension will show a notification and open the settings (or the web documentation) to make the required change easier.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@dansiegel dansiegel enabled auto-merge December 12, 2023 17:22
@dansiegel dansiegel merged commit 6287ba0 into main Dec 12, 2023
40 checks passed
@dansiegel dansiegel deleted the dev/spouliot/recommendations branch December 12, 2023 17:32
Copy link

welcome bot commented Dec 12, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants