Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new UnoTemplate implemented #521

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Arieldelossantos
Copy link

@Arieldelossantos Arieldelossantos commented Jun 13, 2023

GitHub Issue (If applicable): ##513

PR Type

What kind of change does this PR introduce?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Windows navigation is broken after the "ExtendedSplashScreen" appears... will open an issue for this and update the PR when is done

src/ToDo/ToDo.Base/base.props Outdated Show resolved Hide resolved
src/ToDo/ToDo/Views/HomePage.xaml Outdated Show resolved Hide resolved
src/ToDo/ToDo/Views/WelcomePage.xaml Outdated Show resolved Hide resolved
src/ToDo/ToDo/Business/Models/Entity.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo/Business/Models/AppConfig.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo.Tests/Services/TaskListEndpointTests.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo.UITests/Constants.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo.UITests/GlobalUsings.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo.UITests/TestBase.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo.UITests/Given_MainPage.cs Outdated Show resolved Hide resolved
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/implement-new-unotemplate branch from 4b2cec0 to 5c0bc32 Compare June 14, 2023 15:32
src/ToDo/ToDo/AppTheme.cs Outdated Show resolved Hide resolved
src/ToDo/ToDo/IAppTheme.cs Outdated Show resolved Hide resolved
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/implement-new-unotemplate branch 4 times, most recently from 7678159 to f4aa52f Compare June 14, 2023 15:58
carlh98
carlh98 previously approved these changes Jun 14, 2023
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/implement-new-unotemplate branch 3 times, most recently from 53decd3 to bf29799 Compare June 15, 2023 20:04
@kazo0
Copy link
Contributor

kazo0 commented Jun 19, 2023

@Arieldelossantos , some of the build errors are because the path to the files changed in your PR, it looks like an extra ToDo folder was added:

image

The root of the src folder should contain the project folder instead of another ToDo folder

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/implement-new-unotemplate branch from bf29799 to 8b52aff Compare June 20, 2023 14:55
src/ToDo/App.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants