fix: Re-work resource names to avoid issues with xaml merge #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels like we should also be changing the xaml merge tool to detect these overrides, as it hides issues. |
jeromelaban
approved these changes
Mar 8, 2022
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-197.eastus2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes unoplatform/uno#8224
closes unoplatform/uno#8230
closes unoplatform/uno#8228
closes unoplatform/uno#8224
PR Type
What kind of change does this PR introduce?
Prior to introducing the xaml merge task, each Resource Dict in Toolkit.Material and Toolkit.Cupertino were re-defining certiain static resources using the same key but in different file. Now with the xaml merge, we need to use more specific resource keys for each control