Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASM] Listview header and footer are not implemented #1979

Open
3 of 11 tasks
soriyathach opened this issue Oct 28, 2019 · 6 comments
Open
3 of 11 tasks

[WASM] Listview header and footer are not implemented #1979

soriyathach opened this issue Oct 28, 2019 · 6 comments
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)

Comments

@soriyathach
Copy link
Contributor

Current behavior

The listview is not displayed at all if a header or footer is specified on a listview.

Expected behavior

The header, footer and listview content should be displayed.

How to reproduce it (as minimally and precisely as possible)

Seems like nothing is implemented on ListViewBase for wasm:
https://github.com/unoplatform/uno/blob/8dcc6f2d3aa5d57fd3ee96efe5fe73855a45a0da/src/Uno.UI/UI/Xaml/Controls/ListViewBase/ListViewBase.netstd.cs

Environment

Nuget Package:

Package Version(s):
UNO.UI 1.46.196-dev.2440

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: 16.2.0)
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?

@soriyathach soriyathach added kind/bug Something isn't working platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform triage/untriaged Indicates an issue requires triaging or verification labels Oct 28, 2019
@francoistanguay francoistanguay removed the triage/untriaged Indicates an issue requires triaging or verification label Aug 29, 2020
@francoistanguay francoistanguay added this to the 3.1 milestone Aug 29, 2020
@carldebilly carldebilly added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Aug 31, 2020
@francoistanguay francoistanguay removed this from the 3.1 milestone Aug 31, 2020
@agneszitte agneszitte added the project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) label Sep 21, 2020
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@MartinZikmund MartinZikmund added area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 31, 2021
@MartinZikmund MartinZikmund added this to the 3.9 milestone Jun 1, 2021
@jeromelaban jeromelaban removed this from the 3.9 milestone Aug 11, 2021
@michael-hawker
Copy link

Assume this is also for tracking it on the base of ItemsPresenter?

@jeromelaban
Copy link
Member

jeromelaban commented Dec 15, 2022

Assume this is also for tracking it on the base of ItemsPresenter?

@michael-hawker Not necessarily, the implementations of both are different (even in WinUI). Do you need it on either or both? Would ItemsRepeater help?

@michael-hawker
Copy link

michael-hawker commented Dec 15, 2022

@jeromelaban thanks for getting back to me, I just linked to our PR where we're adding new behavior to the SettingsExpander for this with ItemsPresenter as part of it being an ItemsControl.

We could do a bunch of extra work with a StackPanel and ContentPresenters, but it's super simple to hook-in to the existing properties on the ItemsPresenter for this scenario:

     <ItemsPresenter win:Footer="{TemplateBinding ItemsFooter}"
                     win:Header="{TemplateBinding ItemsHeader}"
                     TabFocusNavigation="Local" />

Want me to spin up a separate issue for tracking ItemsPresenter specifically?

@jeromelaban
Copy link
Member

Thanks for the update @michael-hawker, I'll create the issue for ItemsPresenter specifically.

@hawkerm
Copy link

hawkerm commented Jan 3, 2023

Ah, forgot about this. Just tried adding a Header for some content and it's not working on WASM (though I do see the list view items still, unlike the original post). Just the header is missing.

michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Apr 10, 2023
… as a baseline

Tested on UWP, WinUI 3, and WASM
Though ListView usage effected by unoplatform/uno#1979
@michael-hawker
Copy link

michael-hawker commented Apr 10, 2023

FYI, we have a new approach we're investigating in Windows Community Toolkit Labs for a future/modern DataGrid-light replacement: CommunityToolkit/Labs-Windows#415

This is relying on the use of the property Header on ItemsControl/ListView for the inner ItemsPresenter (see #10745 as well), so this prevents it from working with Uno/WASM.

GitHub
Coordinated Panel Problem Statement A lot of times app developers want to display a denser set of data, usually in a grid type format with multiple rows of items that have particular properties (e....

michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Jun 14, 2023
… as a baseline

Tested on UWP, WinUI 3, and WASM
Though ListView usage effected by unoplatform/uno#1979
michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Jul 21, 2023
… as a baseline

Tested on UWP, WinUI 3, and WASM
Though ListView usage effected by unoplatform/uno#1979
michael-hawker added a commit to CommunityToolkit/Labs-Windows that referenced this issue Aug 1, 2023
… as a baseline

Tested on UWP, WinUI 3, and WASM
Though ListView usage effected by unoplatform/uno#1979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Projects
None yet
Development

No branches or pull requests

8 participants