Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XAML] ConverterParameter with string literal is not parsed properly #3049

Closed
jeromelaban opened this issue Apr 25, 2020 · 2 comments · Fixed by #3077
Closed

[XAML] ConverterParameter with string literal is not parsed properly #3049

jeromelaban opened this issue Apr 25, 2020 · 2 comments · Fixed by #3077
Labels
kind/regression Something was working, now it isn't

Comments

@jeromelaban
Copy link
Member

Current behavior

The following XAML does not get generated properly:

<TextBlock Text="{x:Bind Item.StartedAt,Converter={StaticResource StringFormatConverter},ConverterParameter='Started: {0:MMM dd, yyyy hh:mm tt}',Mode=OneWay}" />

where the ConverterParameter does not get parsed properly and is concatenated to the paramaterless group of a binding.

Environment

Nuget Package: 2.2.0

@jeromelaban jeromelaban added the kind/regression Something was working, now it isn't label Apr 25, 2020
jeromelaban added a commit that referenced this issue Apr 25, 2020
@TheRusstler
Copy link

A note which might be helpful.

After updating to Uno 2.2, on iOS the ConverterParameter appears to produce additional unicode left/right arrow characters at the start and end of the string.

For example: ConverterParameter='MyParameter' produces "↔MyParameter↔" to the converter

@jeromelaban
Copy link
Member Author

Indeed, the unicode character is supposed to be used as a workaround for xbind parsing , but the ConverterParameter reader does not remove it properly. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/regression Something was working, now it isn't
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants