Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding TestBox.Text property using OneWay mode is ignored by binding engine #3522

Closed
5 of 8 tasks
MelbourneDeveloper opened this issue Jul 11, 2020 · 3 comments · Fixed by #3840
Closed
5 of 8 tasks

Binding TestBox.Text property using OneWay mode is ignored by binding engine #3522

MelbourneDeveloper opened this issue Jul 11, 2020 · 3 comments · Fixed by #3840
Assignees
@carldebilly
Labels
kind/bug Something isn't working

Comments

@MelbourneDeveloper
Copy link

MelbourneDeveloper commented Jul 11, 2020 •
edited by carldebilly
Loading

Untitled Project

Current behavior

Binding mode is defaulting to TwoWay on WASM while UWP is OneWay

Expected behavior

Binding mode defaults to OneWay - and should honor it.

How to reproduce it (as minimally and precisely as possible)

Run sample. UWP is one way, but WASM is TwoWay

https://www.dropbox.com/s/qxkd4qwuo8q8imd/DataBinding.zip?dl=0

Environment

Windows

Nuget Package:

  <ItemGroup>
    <!-- Note that for WebAssembly version 1.1.1 of the console logger required -->
    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Logging.Filter" Version="1.1.1" />
    <PackageReference Include="Uno.UI" Version="2.4.0" />
    <PackageReference Include="Uno.UI.RemoteControl" Version="2.4.0" Condition="'$(Configuration)'=='Debug'" />
    <PackageReference Include="Uno.Wasm.Bootstrap" Version="1.2.0" />
    <PackageReference Include="Uno.Wasm.Bootstrap.DevServer" Version="1.2.0" />
  </ItemGroup>

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Windows
  • Build tasks
  • Solution Templates
@MelbourneDeveloper MelbourneDeveloper added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Jul 11, 2020
@MelbourneDeveloper
Copy link
Author

@jeromelaban

@jeromelaban jeromelaban added priority/backlog and removed triage/untriaged Indicates an issue requires triaging or verification labels Jul 11, 2020
@carldebilly carldebilly self-assigned this Aug 18, 2020
@carldebilly
Copy link
Member

carldebilly commented Aug 18, 2020 •
edited
Loading

Just reproduced easily on the Playground on this address:
https://playground.platform.uno/#6549dbf7

I also confirm the problem is present on both iOS and Wasm. Can't reproduce on Android.

carldebilly added a commit that referenced this issue Aug 18, 2020
@carldebilly
fix(textbox): A binding on the TextBox.Text property were always tr…
d2b0b80 
…eated as a `TwoWay` binding.

Fix #3522
@carldebilly carldebilly changed the title Default Binding Mode Discrepancy (WASM) Binding TestBox.Text property using OneWay mode is ignored by binding engine Aug 18, 2020
@carldebilly carldebilly mentioned this issue Aug 18, 2020
Merged
6 tasks
@carldebilly
Copy link
Member

This bug has been fixed. Thanks for reporting it!
Fix available in Uno.UI v3.1.0-dev.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carldebilly carldebilly

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BindingExpression.UpdateSource() won't update unless binding is TwoWay unoplatform/uno
3 participants
@carldebilly @jeromelaban @MelbourneDeveloper