Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUX:NavigationView Incorrect Top Content Padding #4793

Closed
3 of 24 tasks
robloo opened this issue Dec 23, 2020 · 1 comment · Fixed by #4827
Closed
3 of 24 tasks

MUX:NavigationView Incorrect Top Content Padding #4793

robloo opened this issue Dec 23, 2020 · 1 comment · Fixed by #4827
Assignees
@MartinZikmund
Labels
kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Milestone
3.5

Comments

@robloo
Copy link
Contributor

robloo commented Dec 23, 2020 •
edited
Loading

Current behavior

Using the new MUX NavigationView available in Uno 3.4, some display modes have content padding at the top that prevents the Content from appearing next to the hamburger menu.

image

This issue does not exist in Uno's Windows.UI.Xaml version of the control.

Expected behavior

The "Accounts" title should appear next to the hamburger menu and the 'Edit' Button should be at the top. There should be no top content padding in NavigationViewPaneDisplayMode.LeftMinimal.

image
(image from UWP)

How to reproduce it (as minimally and precisely as possible)

  1. Create a navigation view with PaneDisplayMode = Microsoft.UI.Xaml.Controls.NavigationViewPaneDisplayMode.LeftMinimal
  2. Add any NavigationView.Content with top vertical alignment
  3. The Content is always below the hamburger menu

Workaround

Negative margins I would expect.

Environment

  • Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
  • Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia
  • Uno.SourceGenerationTasks
  • Uno.UI.RemoteControl / Uno.WinUI.RemoteControl
  • Other:

Nuget Package Version(s):3.4.0

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

IDE:

  • Visual Studio 2017 (version: )
  • Visual Studio 2019 (version: )
  • Visual Studio for Mac (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )
  • Visual Studio Code (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?
@robloo robloo added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Dec 23, 2020
@robloo robloo changed the title NavigationView Incorrect Top Content Padding MUX:NavigationView Incorrect Top Content Padding Dec 23, 2020
@MartinZikmund MartinZikmund removed the triage/untriaged Indicates an issue requires triaging or verification label Dec 24, 2020
@MartinZikmund MartinZikmund self-assigned this Dec 24, 2020
@MartinZikmund MartinZikmund added the project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) label Dec 24, 2020
@MartinZikmund
Copy link
Member

Thanks for the report, will check it 👍

@MartinZikmund MartinZikmund added this to the 3.5 milestone Dec 24, 2020
MartinZikmund added a commit to MartinZikmund/Uno that referenced this issue Jan 5, 2021
@MartinZikmund
fix(NavigationView): Content top padding is not correct
78fdd7f 
- Fixes issue unoplatform#4793 where Content top padding was not correctly applied due to the fact that API information reported API availability matching SDK 17134, while Uno supports 19041
- Updates TabView FluentStyles style to be buildable with new contract support, because {Binding} is not supported in Style Setters yet (unoplatform#4826)
MartinZikmund added a commit to MartinZikmund/Uno that referenced this issue Jan 5, 2021
@MartinZikmund
fix(NavigationView): Content top padding is not correct
444aa14 
- Fixes issue unoplatform#4793 where Content top padding was not correctly applied due to the fact that API information reported API availability matching SDK 17134, while Uno supports 19041
- Updates TabView FluentStyles style to be buildable with new contract support, because {Binding} is not supported in Style Setters yet (unoplatform#4826)
@MartinZikmund MartinZikmund mentioned this issue Jan 5, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinZikmund MartinZikmund

Labels
kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

fix(NavigationView): Content top padding is not correct MartinZikmund/Uno
2 participants
@MartinZikmund @robloo