Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUX NavigationView: Selection indicator does not move to Settings item #4809

Closed
1 of 24 tasks
MartinZikmund opened this issue Dec 29, 2020 · 0 comments · Fixed by #4811
Closed
1 of 24 tasks

MUX NavigationView: Selection indicator does not move to Settings item #4809

MartinZikmund opened this issue Dec 29, 2020 · 0 comments · Fixed by #4811
Assignees
@MartinZikmund
Labels
area/navigationview 🧭 Categorizes an issue or PR as relevant to the NavigationView control kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Milestone
3.5

Comments

@MartinZikmund
Copy link
Member

MartinZikmund commented Dec 29, 2020 •
edited
Loading

Current behavior

When Settings item is selected, the selection indicator does not appear.

Expected behavior

Should appear

How to reproduce it (as minimally and precisely as possible)

Workaround

Environment

Nuget Package:

  • Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
  • Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia
  • Uno.SourceGenerationTasks
  • Uno.UI.RemoteControl / Uno.WinUI.RemoteControl
  • Other:

Nuget Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

IDE:

  • Visual Studio 2017 (version: )
  • Visual Studio 2019 (version: )
  • Visual Studio for Mac (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )
  • Visual Studio Code (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?
@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification area/navigationview 🧭 Categorizes an issue or PR as relevant to the NavigationView control and removed triage/untriaged Indicates an issue requires triaging or verification labels Dec 29, 2020
@MartinZikmund MartinZikmund added this to the 3.5 milestone Dec 29, 2020
@MartinZikmund MartinZikmund added the project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) label Dec 29, 2020
@MartinZikmund MartinZikmund self-assigned this Dec 29, 2020
MartinZikmund added a commit to MartinZikmund/Uno that referenced this issue Dec 30, 2020
@MartinZikmund
fix: Make NavigationView Settings item selectable
69318b4 
- Fixes unoplatform#4809 - in some cases on some Uno targets, the lifecycle events are in such order that causes presenters of dynamically added NavigationViewItems not to be initialized properly. These changes work around this problem when selection indicator is requeste. These changes can be reverted when unoplatform#4689 is fixed.
@MartinZikmund MartinZikmund mentioned this issue Dec 30, 2020
Merged
6 tasks
@mergify mergify bot closed this as completed in #4811 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinZikmund MartinZikmund

Labels
area/navigationview 🧭 Categorizes an issue or PR as relevant to the NavigationView control kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

fix: NavigationView item selection, load on Skia MartinZikmund/Uno
1 participant
@MartinZikmund