Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gallery][iOS/Android] Overview - At the bottom of the page 'Share' link is not working #9012

Open
sakshi173 opened this issue Jun 10, 2022 · 16 comments
Open

[Gallery][iOS/Android] Overview - At the bottom of the page 'Share' link is not working #9012

sakshi173 opened this issue Jun 10, 2022 · 16 comments
Assignees
@Arieldelossantos
Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified

Comments

@sakshi173
Copy link

Current behavior

Share link

Expected behavior

when click/tap on the share link the page should be available to share.

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP
  2. Go to the 'Overview' Page.
  3. Scroll down to the 'Overview' Page.
  4. Go to the 'Share' link at the bottom of the page.
  5. Tap/click on the 'Share' link.
  6. Observe that nothing is happening.

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

iOS, Android

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@sakshi173 sakshi173 added kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform triage/untriaged Indicates an issue requires triaging or verification area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 10, 2022
@agneszitte agneszitte self-assigned this Jun 13, 2022
@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Jul 4, 2022

working fine on:

  • generic droid emulator
  • huawei honor10 (droid)
  • iPhone 13 Pro Max iOS 15.5
    all of them opens a "sharing" popup specific to the os

@Xiaoy312 Xiaoy312 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2022
@Xiaoy312 Xiaoy312 added the project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery label Jul 7, 2022
@sakshi173
Copy link
Author

Still this bug is reproducible, due to that opening it.

@sakshi173 sakshi173 reopened this Jul 14, 2022
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Dec 2, 2022
@agneszitte
Copy link
Contributor

@sakshi173 is this issue still reproducible lately please?

@sakshi173
Copy link
Author

@agneszitte-nventive Yes this issue is still present. Please look into it.

@agneszitte
Copy link
Contributor

agneszitte commented Feb 2, 2023 •
edited
Loading

@agneszitte-nventive Yes this issue is still present. Please look into it.

Thanks a lot for the update @sakshi173 really appreciated it!

@rajamatt
Copy link
Contributor

rajamatt commented Jun 16, 2023 •
edited
Loading

@kazo0 Can't repro this for iOS or Android. Clicking on share link opens native share menu.

iOS: iphone 11 iOS 15
Android: Samsung galaxy A14 Android 13.0

@kazo0
Copy link
Contributor

kazo0 commented Jun 16, 2023

@sakshi173 you're seeing this on mobile devices or on a web browser?

@sakshi173
Copy link
Author

@rajamatt and @kazo0 , I am seeing in mobile device and when clicking on share link nothing is happening.

share.link.issue.MP4

@rajamatt
Copy link
Contributor

Thank you @sakshi173

@kazo0 I'll let you decide what's next for this issue as I can't repro it, I tried looking in the code and changing stuff but nothing looks out of place

@MartinZikmund MartinZikmund changed the title [Gallery][iOS/Android]Overview- At the bottom of the page 'Share' link is not working. [Gallery][iOS/Android] Overview - At the bottom of the page 'Share' link is not working Jul 31, 2023
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 31, 2023
@MartinZikmund
Copy link
Member

@sakshi173 Which iOS version is this? And does it still repro on Android too?

@sakshi173
Copy link
Author

@MartinZikmund , Yes Still this issue is present for both Android and iOS.
I am checking for iOS version 15.6.1 and Model is iphone 13 pro Max.

@rajamatt rajamatt removed their assignment Aug 24, 2023
@Arieldelossantos Arieldelossantos self-assigned this Aug 31, 2023
@Youssef1313
Copy link
Member

Looking at the code, it's expected this is happening:

https://github.com/unoplatform/Uno.Gallery/blob/9fb342c26e0648332eb0adfb62dd2be0b343d950/Uno.Gallery/Uno.Gallery.Shared/Controls/SamplePageLayout.cs#L167-L173

It only works for !NET6_0_OR_GREATER, which means it used to work only for Xamarin targets which are gone now.

@Youssef1313 Youssef1313 self-assigned this Sep 1, 2023
@Youssef1313
Copy link
Member

I'm looking into it

@Youssef1313 Youssef1313 mentioned this issue Sep 1, 2023
Draft
6 tasks
@Youssef1313
Copy link
Member

Fix for Android: unoplatform/Uno.Gallery#942
I couldn't get iOS working though. Not very familiar with iOS APIs and I think I might be doing something very wrong, though I left the code I wrote in #942 as a starting point (if needed).

@Arieldelossantos
Copy link

yes, i've noticed too that it was removed on .Net6 upgrade... i was trying to find a workaround based on this documentation from Uno... Sharing Content

@Youssef1313
Copy link
Member

@Arieldelossantos Oh I didn't know about that!
I think your approach could work better. I'll mark my PR as a draft then.

@Arieldelossantos Arieldelossantos mentioned this issue Sep 5, 2023
Open
6 tasks
@Youssef1313 Youssef1313 removed their assignment Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arieldelossantos Arieldelossantos

Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/themes-toolkit-gallery Categorizes an issue or PR as relevant to Uno.Themes\Toolkit\Gallery triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@MartinZikmund @Xiaoy312 @kazo0 @jeromelaban @agneszitte @Youssef1313 @Arieldelossantos @rajamatt @sakshi173