fix(share): fix share button unresponsive on Overview for iOS and Android #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Sep 5, 2023
| args.Request.Data.Properties.Title = "Uno Gallery - Share-Sample Title"; | ||
| args.Request.Data.Properties.Description = "See this awesome project:"; | ||
|
|
||
| args.Request.Data.SetWebLink(new Uri("https://gallery.platform.uno/")); |
There was a problem hiding this comment.
This doesn't share yhe sample I believe?
There was a problem hiding this comment.
when you say the sample... what do you mean?? what this does is shares the URL :/
what was the old behavior??
There was a problem hiding this comment.
The old behavior is that the shared link corresponds to a specific sample and design (fluent, material, cupertino, agnostic).
Opening the link should then open the app on the specific sample.
See my PR for the approach I took for this.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-967.eastus2.3.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): unoplatform/uno#9012
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Share button on Overview page is not working
What is the new behavior?
Share button is working and shares the Lunk to UnoGallery app
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Haven't tested iOS because it is not deploying to my physical device