Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Avoid using Regex in AndroidResourceNameEncoder #11990

Merged
merged 1 commit into from
Apr 25, 2023
Merged

perf: Avoid using Regex in AndroidResourceNameEncoder #11990

merged 1 commit into from
Apr 25, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 15, 2023 •
edited
Loading

GitHub Issue (If applicable): #8597

image

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 mentioned this pull request Apr 15, 2023
Open
71 tasks
@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Youssef1313
Copy link
Member Author

@jeromelaban Is this ready to merge?

@jeromelaban jeromelaban merged commit 155cb5c into unoplatform:master Apr 25, 2023
@Youssef1313 Youssef1313 deleted the perf-android-regex branch April 25, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @jeromelaban @spouliot