Check for dataContext to avoid recyclingTemplate when unneeded #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasChampagne
force-pushed
the
dev/nich/template-recycling
branch
2 times, most recently
from
0d23860 to
fbc39b1
Compare
ghuntley
added
platform/android 🤖
...mplesApp.UITests/Windows_UI_Xaml_Controls/ToggleSwitchTests/UnoSamples_Tests.ToggleSwitch.cs
Outdated
Show resolved
Hide resolved
...Tests.Shared/Windows_UI_Xaml_Controls/ToggleSwitchControl/ToggleSwitch_TemplateReuse.xaml.cs
Outdated
Show resolved
Hide resolved
NicolasChampagne
force-pushed
the
dev/nich/template-recycling
branch
from
e03f65d to
6df9fb7
Compare
jeromelaban
reviewed
Jul 17, 2019
...mplesApp.UITests/Windows_UI_Xaml_Controls/ToggleSwitchTests/UnoSamples_Tests.ToggleSwitch.cs
Outdated
Show resolved
Hide resolved
...mplesApp.UITests/Windows_UI_Xaml_Controls/ToggleSwitchTests/UnoSamples_Tests.ToggleSwitch.cs
Outdated
Show resolved
Hide resolved
...Tests.Shared/Windows_UI_Xaml_Controls/ToggleSwitchControl/ToggleSwitch_TemplateReuse.xaml.cs
Outdated
Show resolved
Hide resolved
NicolasChampagne
force-pushed
the
dev/nich/template-recycling
branch
from
ac47f55 to
7181a9f
Compare
NicolasChampagne
force-pushed
the
dev/nich/template-recycling
branch
from
7181a9f to
6a97a9b
Compare
NicolasChampagne
requested review from
jeromelaban and
MatFillion
and removed request for
jeromelaban and
MatFillion
davidjohnoliver
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
Would recycle template even when unneeded
What is the new behavior?
Won't recycle template even when unneeded
PR Checklist
Please check if your PR fulfills the following requirements:
Internal Issue (If applicable):
https://nventive.visualstudio.com/Umbrella/_workitems/edit/144025