Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid using DefaultConversionExtensions #12700

Merged

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 26, 2023

GitHub Issue (If applicable): Part of #8597

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at 016b624

This pull request enhances the data binding system for dependency properties in Uno.UI, by optimizing the type conversion logic and adding support for fast string-to-boolean conversion. It modifies the BindingPropertyHelper class and adds a new file BindingPropertyHelper.FastConvert.cs with helper methods for fast conversion.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one :) Those extensions are not particularly fast.

src/Uno.UI/DataBinding/BindingPropertyHelper.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jun 27, 2023
@Youssef1313 Youssef1313 marked this pull request as ready for review June 27, 2023 12:56
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one :) Those extensions are not particularly fast.

@jeromelaban jeromelaban merged commit 7644550 into unoplatform:master Jun 29, 2023
@jeromelaban
Copy link
Member

🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants