-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Avoid using DefaultConversionExtensions #12700
Merged
jeromelaban
merged 9 commits into
unoplatform:master
from
Youssef1313:avoid-default-conversion-ext
Jun 29, 2023
Merged
perf: Avoid using DefaultConversionExtensions #12700
jeromelaban
merged 9 commits into
unoplatform:master
from
Youssef1313:avoid-default-conversion-ext
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Jun 26, 2023
jeromelaban
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one :) Those extensions are not particularly fast.
github-actions
bot
added
the
area/automation
Categorizes an issue or PR as relevant to project automation
label
Jun 27, 2023
Youssef1313
force-pushed
the
avoid-default-conversion-ext
branch
from
June 27, 2023 14:07
346cd51
to
fc802a7
Compare
jeromelaban
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one :) Those extensions are not particularly fast.
🚀🚀 |
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): Part of #8597
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 016b624
This pull request enhances the data binding system for dependency properties in Uno.UI, by optimizing the type conversion logic and adding support for fast string-to-boolean conversion. It modifies the
BindingPropertyHelper
class and adds a new fileBindingPropertyHelper.FastConvert.cs
with helper methods for fast conversion.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):