Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Adjust UnoIslands.Skia.Wpf to properly have Uno.UI.Tasks #14585

Merged
merged 1 commit into from
Nov 28, 2023
Merged

build: Adjust UnoIslands.Skia.Wpf to properly have Uno.UI.Tasks #14585

merged 1 commit into from
Nov 28, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 27, 2023 •
edited by ghost
Loading

GitHub Issue (If applicable): This change appears to fix #14189 for me locally.

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖[deprecated] Generated by Copilot at 8c1b3e5

This change updates the UnoIslands.Skia.Wpf.csproj file to use the UnoSourceGenerator and the UnoXamlGenerator tasks for resource generation. This enables the UnoIslands.Skia.Wpf sample project to use the latest features of Uno and .NET.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Nov 27, 2023
@Youssef1313 Youssef1313 mentioned this pull request Nov 27, 2023
Closed
@limeniye
Copy link
Contributor

The test was successful

@jeromelaban
Copy link
Member

The test was successful

Thanks for validating!

@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14585/index.html

@nventive-devops
Copy link
Contributor

The build 103298 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 76, ios: 216, ios-Snap: 861, skia-gtk-screenshots: 19, skia-wpf-screenshots: 19, wasm: 28, wasm-automated-net7.0-UWP-Benchmarks: 0, wasm-automated-net7.0-UWP-Default: 30, wasm-automated-net7.0-UWP-RuntimeTests: 0, wasm-automated-net7.0-WinUI-RuntimeTests: 0

Details

  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 76 changed over 1049

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
    • Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
    • ListView_ListViewLargeLegacy_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewLargeLegacy
    • ListView_ListView_TransformsOnList_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_TransformsOnList
    • Scrolling_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Nested_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Nested
    • Scrolling_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_SnapPoints_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_SnapPoints
    • ScrollViewer_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Padding_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Padding
    • BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage
    • Control_BasicEnability_UITests_Shared_Windows_UI_Xaml_Enability_BasicEnability
    • Grid_Grid_left_column_Auto_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_left_column_Auto
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
    • ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_ListViewGroupedLargeLegacy_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedLargeLegacy
    • ListView_ListViewGroupedVariableHeightComplexTemplate_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedVariableHeightComplexTemplate
    • NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
    • NavigationView_MUXControlsTestApp_PaneLayoutTestPage_MUXControlsTestApp_PaneLayoutTestPage
    • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream

  • ios: 216 changed over 266

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • FocusManager_FocusDirection_Down_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • Image_Source_Nullify_image_source_nullify_loaded
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_Initial_State
    • ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-2
    • Screenshots_Image_Stretch_Alignment_Taller_Mode-3
    • TextBox_IsReadOnly_AcceptsReturn_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn
    • TextBox_MaxLength_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_MaxLength
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • BitmapSource_PixelSize_ImageSource_PixelSize_-_Result
    • Check_ListView_Swallows_Measure_after_scroll
    • HyperlinkButton_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_HyperlinkButton_IsEnabled_Automated
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_ExpandableItem_ExpandSingleItem_Expanded_State
    • ListView_ExpandableItem_ExpandSingleItem_Initial_State
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-0

  • ios-Snap: 861 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_Opacity_TextBlock_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_Opacity_TextBlock
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill
    • AutoSuggestBox_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
    • Border_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmargin
    • Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Border_Simple_with_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Simple_with_Radius
    • Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • Buttons_Button_Opacity_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_Opacity_Automated
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_two_grids_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_two_grids
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_UIElementClipping_SamplesApp_Windows_UI_Xaml_Clipping_UIElementClipping
    • ComboBox_ComboBox_With_ItemContainerStyle_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_With_ItemContainerStyle
    • ComboBox_ComboBox_With_ItemTemplate_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_With_ItemTemplate
    • ContentControl_ContentControl_UnsetContent_GenericApp_Views_Content_UITests_ContentControlTestsControl_ContentControl_UnsetContent
    • ContentControl_ContentControl_WithInlineContent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithInlineContent
    • Default_UITests_Windows_UI_Xaml_Clipping_Clipping4273_UITests_Windows_UI_Xaml_Clipping_Clipping4273
    • Default_UITests_Windows_UI_Xaml_Clipping_CornerRadiusControls_UITests_Windows_UI_Xaml_Clipping_CornerRadiusControls
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • FlipView_FlipView_Buttons_UITests_Windows_UI_Xaml_Controls_FlipView_FlipView_Buttons
    • Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout

  • skia-gtk-screenshots: 19 changed over 1138

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView-ListViewSelectedItems.png
    • MUX-WinUIProgressRing_CustomSources.png
    • TextBlock-TextBlockMultilineInStarStackPanel.png
    • TextBlock-TextBoxSizeChanging.png
    • MediaPlayerElement-Mini player.png
    • PipsPager-PipsPagerExamples.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • MediaPlayerElement-Using .3gp.png
    • MUX-WinUIProgressRingPage.png
    • MUX-NavigationViewRS4Page.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • Windows.Graphics.Display-DisplayInformation.png
    • Windows.UI.Composition-CompositionMaskBrush.png
    • Windows.UI.Composition-CompositionVisualSurface.png
    • Windows.UI.Composition-RedirectVisual.png
    • WinUI-PipsPagerExamples.png

  • skia-wpf-screenshots: 19 changed over 1138

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image-ImageSourceStream.png
    • MUX-WinUIProgressRing_CustomSources.png
    • MUX-WinUIProgressRingPage.png
    • Brushes-Ellipse.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Automation-AutomationProperties_Name.png
    • DragAndDrop-DragDrop_TestPage.png
    • Image-UniformToFill100x100.png
    • PipsPager-PipsPagerExamples.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • ListView-ListViewSelectedItems.png
    • Transform-TransformToVisual_Translate2d.png
    • Windows.UI.Composition-CompositionMaskBrush.png
    • Windows.UI.Composition-CompositionVisualSurface.png
    • Windows.UI.Composition-RedirectVisual.png
    • WinUI-PipsPagerExamples.png

  • wasm: 28 changed over 1045

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
    • UITests.Windows_UI_ViewManagement.ApplicationViewSizing
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_Fill
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • MUXControlsTestApp.SwipeControlPage2
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • initial_state
    • MUXControlsTestApp.PipsPagerExamples
    • SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigation
    • UITests.Windows_UI_Xaml_Shapes.LineStretchModes
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • MUXControlsTestApp.NavigationViewRS4Page
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_TransformsOnList
    • MUXControlsTestApp.NavigationViewMenuItemStretchPage
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mp3_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Ogg_Extension
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage

  • wasm-automated-net7.0-UWP-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-UWP-Default: 30 changed over 1938

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Default_StrokeThickness_MyPolygon
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
    • MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
    • Check_ListView_Swallows_Measure_after_scroll
    • PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal

  • wasm-automated-net7.0-UWP-RuntimeTests: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests: 0 changed over 1

@jeromelaban jeromelaban merged commit f3cc757 into master Nov 28, 2023
87 checks passed
@jeromelaban jeromelaban deleted the Youssef1313/fix-build-skia branch November 28, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skia build fails with The "RuntimeAssetsSelectorTask_v0" task was not found
6 participants
@Youssef1313 @limeniye @jeromelaban @unodevops @nventive-devops @ajpinedam