Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uncomment a Uno-specific commented line in TabView #14701

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #4925

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14701/index.html

@jeromelaban
Copy link
Member

@ramezgerges can you validate if any test fails or if a new one needs to be added?

@MartinZikmund
Copy link
Member

I think workaround could have been there because iOS, we probably need to check there before it is merged as well

@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14701/index.html

@jeromelaban
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14701/index.html

@jeromelaban jeromelaban disabled auto-merge December 20, 2023 12:55
@jeromelaban jeromelaban merged commit 994a50b into unoplatform:master Dec 20, 2023
81 of 85 checks passed
@ramezgerges ramezgerges deleted the tabview_remove_updatelayout_unospecific branch December 20, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested measure on ListView may cause duplicate items
4 participants