Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: implement PointerUpdateKind enum #1493

Merged
merged 1 commit into from
Sep 7, 2019
Merged

feature: implement PointerUpdateKind enum #1493

merged 1 commit into from
Sep 7, 2019

Conversation

ghuntley
Copy link
Member

@ghuntley ghuntley commented Sep 5, 2019 •
edited
Loading

GitHub Issue (If applicable): fixes #1492

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

[Uno.NotImplemented]

What is the new behavior?

As per https://docs.microsoft.com/en-us/uwp/api/windows.ui.input.pointerupdatekind

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@ghuntley ghuntley added kind/enhancement New feature or request platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Sep 5, 2019
@ghuntley ghuntley force-pushed the dev/ghuntley/PointerUpdateKind branch from c22dfac to 44d226f Compare September 5, 2019 17:02
@davidjohnoliver
Copy link
Contributor

Are you planning to implement it?

@ghuntley ghuntley changed the title feature: implement the PointerUpdateKind Enum [WIP] feature: implement the PointerUpdateKind Sep 5, 2019
@ghuntley ghuntley added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2019
@ghuntley ghuntley changed the title [WIP] feature: implement the PointerUpdateKind [WIP] feature: implement PointerUpdateKind Sep 5, 2019
@dr1rrb
Copy link
Member

dr1rrb commented Sep 6, 2019 •
edited by unfurl-links bot
Loading

Are you planning to implement it?

Actually he should not, I already did it in my pointers PR https://github.com/unoplatform/uno/pull/1256/files#diff-b57803513cd4eba2ea50571f1c9554a0R140

But I forgot to remove the NotImplemented attribute, so this PR is welcome!

GitHub
GitHub Issue (If applicable): #1162 #864 #1227 #643 #221 (Preliminary work only) Refactor the touches (on iOS only at this point)

Bugfix
Feature

What is the current behavior?
We face multiple iss...

@ghuntley ghuntley changed the title [WIP] feature: implement PointerUpdateKind feature: implement PointerUpdateKind enum Sep 7, 2019
@ghuntley ghuntley removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2019
@ghuntley ghuntley merged commit bcb4484 into master Sep 7, 2019
@ghuntley ghuntley deleted the dev/ghuntley/PointerUpdateKind branch September 7, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Windows.UI.Input.PointerUpdateKind
3 participants
@ghuntley @davidjohnoliver @dr1rrb