Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridview): fix header being placed in wrong orientation (backport #15272) #15284

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 31, 2024

This is an automatic backport of pull request #15272 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15284/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15284/index.html

@jeromelaban jeromelaban enabled auto-merge January 31, 2024 13:43
@nventive-devops
Copy link
Contributor

The build 110745 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 56, ios: 68, ios-Snap: 858, skia-gtk-screenshots: 16, skia-wpf-screenshots: 18, wasm: 29, wasm-automated-net7.0-UWP-Default-automated: 39, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 1, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 1

Details
  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 56 changed over 1049

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush
    • ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DisplayMemberPath_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DisplayMemberPath
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_NoSize_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_NoSize
    • ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margins_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margins
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Source_Nullify_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Source_Nullify
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Transforms_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Transforms
    • ListView_ListViewVariableHeightComplexTemplate_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewVariableHeightComplexTemplate
    • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_UseTargetSizeLate_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_UseTargetSizeLate
    • ListView_ListViewStackPanel_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewStackPanel
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
  • ios: 68 changed over 266

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_Collapsed_State
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
    • ListView_ExpandableItem_ExpandSingleItem_Initial_State
    • ListView_Selection_Events_Ordering_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Events
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-3
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
    • ListView_ExpandableItem_ExpandMultipleItems_Initial_State
    • ListView_ObservableCollection_Creation_Count_UITests_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_CreationCount
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_ObservableCollection_Creation_Count_Added_above
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • Check_ListView_Swallows_Measure_after_scroll
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ScrollViewer_WhenAsync_RunIdleAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesMode
    • ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
  • ios-Snap: 858 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Border_OnepxThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadius
    • Brushes_EllipsemaskingEllipseSuperpositionPanel_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseSuperpositionPanel
    • Brushes_ImageBrush_Stretch_None_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_Stretch_None
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_UIElementClipping_SamplesApp_Windows_UI_Xaml_Clipping_UIElementClipping
    • ComboBox_ComboBox_ItemDataContext_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemDataContext
    • ComboBox_ComboBox_ItemsSource_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemsSource
    • CommandBar_UITests_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Native_With_Content_UITests_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Native_With_Content
    • CommandBar_UITests_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Native_With_TextBox_UITests_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Native_With_TextBox
    • ContentControl_ContentControl_WithPadding_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithPadding
    • ContentPresenter_ContentPresenter_Background_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Background
    • Default_UITests_Toolkit_ElevatedView_Corners_UITests_Toolkit_ElevatedView_Corners
    • Default_UITests_Toolkit_ElevatedView_Dimensions_UITests_Toolkit_ElevatedView_Dimensions
    • Default_Uno_UI_Samples_UITests_Image_Image_Margin_Uno_UI_Samples_UITests_Image_Image_Margin
    • Default_Uno_UI_Samples_UITests_Image_Image_UseTargetSize_Uno_UI_Samples_UITests_Image_Image_UseTargetSize
    • Flyouts_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
    • Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Content_ThemeResource_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Content_ThemeResource
    • Focus_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • Fonts_UITests_Windows_UI_Xaml_Media_FontTests_DynamicFont_UITests_Windows_UI_Xaml_Media_FontTests_DynamicFont
    • Gesture_Recognizer_VisualStates_ComboBoxItem_UITests_Shared_Windows_UI_Input_VisualStatesTests_ComboBoxItem
  • skia-gtk-screenshots: 16 changed over 1098

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Progress-ProgressRingHeightTest.png
    • WinUI-PipsPagerExamples.png
    • ListView-ListViewSelectedItems.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRingPage.png
    • GridView-GridViewVariableItemHeight.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • PipsPager-PipsPagerExamples.png
    • Progress-WindowsProgressRing_GH1220.png
    • MediaPlayerElement-Mini player.png
    • MediaPlayerElement-Using .avi.png
    • MUX-WinUIProgressRingPage.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • Microsoft.UI.Composition-RedirectVisual.png
  • skia-wpf-screenshots: 18 changed over 1098

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image-UniformToFill100x100.png
    • ListView-ListViewSelectedItems.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • PipsPager-PipsPagerExamples.png
    • GridView-GridViewVariableItemHeight.png
    • Brushes-Ellipse.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Transform-TransformToVisual_Translate2d.png
    • DragAndDrop-DragDrop_TestPage.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • WinUI-PipsPagerExamples.png
    • Progress-WinUIProgressRingPage.png
  • wasm: 29 changed over 1045

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • initial_state
    • UITests.Windows_UI_Xaml_Shapes.PathStretchModes
    • Uno.UI.Samples.Content.UITests.GridView.GridViewVariableItemHeight
    • MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
    • UITests.Windows_UI_ViewManagement.ApplicationViewSizing
    • UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
    • UITests.Windows_Media.MediaPlayerTests
    • MUXControlsTestApp.NavigationViewMenuItemStretchPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • MUXControlsTestApp.PipsPagerExamples
    • MUXControlsTestApp.SwipeControlPage2
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
  • wasm-automated-net7.0-UWP-Default-automated: 39 changed over 1948

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewVariableItemHeight_Uno_UI_Samples_Content_UITests_GridView_GridViewVariableItemHeight
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Check_ListView_Swallows_Measure_after_scroll
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • ContentDialog_Simple_NotLightDismissible_1_ContentDialog_Opened
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry
    • Performance_Dopes_UITests_Windows_UI_Xaml_Performance_Performance_Dopes
    • Pickers_TimePicker_Flyout_Automated_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry
  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunBenchmarks_Benchmarks_Shared_Controls_BenchmarkDotNetTestsPage
  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

@jeromelaban jeromelaban merged commit 73628cb into release/stable/5.1 Jan 31, 2024
91 of 92 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.1/pr-15272 branch January 31, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants