[Android] Fix invalid ImageBrush stack overflow with delayed im… #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/v2-0
branch
from
39f5bd9 to
6fc0863
Compare
agneszitte
approved these changes
Sep 23, 2019
davidjohnoliver
approved these changes
Sep 23, 2019
jeromelaban
added
the
ready-to-merge
ghuntley
added
platform/android 🤖
ghuntley
reviewed
Sep 24, 2019
| @@ -0,0 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <network-security-config> | |||
| <base-config cleartextTrafficPermitted="true" > | |||
There was a problem hiding this comment.
I don't think we should be shipping with insecure defaults. How about we change the UI test to use https:// instead of http:// and then burn this file + related changes.
There was a problem hiding this comment.
We're not shipping this app. The point of this modification is to restore the many samples that use this kind of urls, and there are many that are not tested properly after the upgrade to Android 9.0.
I'll move this change to another PR, as there are about 270 Urls that need to be validated to determine if they do work in https.
ghuntley
reviewed
Sep 24, 2019
| @@ -2,6 +2,6 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="uno.platform.unosampleapp" android:versionCode="1" android:versionName="1.0" android:installLocation="auto"> | |||
| <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="28" /> | |||
| <uses-permission android:name="android.permission.VIBRATE" /> | |||
| <application android:label="SamplesApp"></application> | |||
| <application android:label="SamplesApp" android:networkSecurityConfig="@xml/network_security_config"></application> | |||
ghuntley
reviewed
Sep 24, 2019
ghuntley
reviewed
Sep 24, 2019
...lesApp/UITests.Shared/Windows_UI_Xaml_Media/ImageBrushTests/ImageBrush_SameWithDelay.xaml.cs
Outdated
Show resolved
Hide resolved
ghuntley
reviewed
Sep 24, 2019
...lesApp/UITests.Shared/Windows_UI_Xaml_Media/ImageBrushTests/ImageBrush_SameWithDelay.xaml.cs
Outdated
Show resolved
Hide resolved
ghuntley
suggested changes
Sep 24, 2019
ghuntley
added
do-not-merge/work-in-progress
jeromelaban
force-pushed
the
dev/jela/v2-0
branch
from
c9b419d to
08085c8
Compare
ghuntley
changed the title
ghuntley
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): unoplatform/Uno.WindowsCommunityToolkit#59
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using an
ImageBrushon a shape may result in a stack overflow if the image has already been loaded.What is the new behavior?
Reusing a image does not crash the app.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):