chore: HR indicator support material #17473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
reviewed
Jul 11, 2024
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17473/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17473/index.html |
|
The build 132411 found UI Test snapshots differences: Details
|
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17473/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17473/index.html |
|
The build 132568 found UI Test snapshots differences: Details
|
kazo0
force-pushed
the
dev/mara/hr-indicator-material
branch
from
60d4c0c to
9fdddc4
Compare
dr1rrb
approved these changes
Jul 15, 2024
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17473/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17473/index.html |
|
(Tested locally, all good on my side) |
|
@Mergifyio backport release/stable/5.3 |
✅ Backports have been created
|
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Jul 15, 2024
…5.3/pr-17473 chore: HR indicator support material (backport #17473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #17425, closes https://github.com/unoplatform/uno-private/issues/522
PR Type
What kind of change does this PR introduce?
What is the current behavior?
(Using the Material Uno feature, the indicator button takes Material style, which isn't great)
What is the new behavior?
Using Material feature:
Not using Material feature (same as before):
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):