Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix the document of Animation output log filter. #17594

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Jul 18, 2024

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

We can not find any animation log after builder.AddFilter("Windows.UI.Xaml.Media.Animation", LogLevel.Debug);

What is the new behavior?

We can find the animation log after builder.AddFilter("Microsoft.UI.Xaml.Media.Animation", LogLevel.Debug);

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

I test the code in my demo project, and I can find the log message of animation in console.

            builder.AddFilter("Windows.UI.Xaml.Media.Animation", LogLevel.Debug);
            builder.AddFilter("Microsoft.UI.Xaml.Media.Animation", LogLevel.Debug);

See my demo code: https://github.com/lindexi/lindexi_gd/blob/72617d0df7ae8e54548ce217dd50d5bfa5054133/UnoDemo/WernujarlerhelkayFebairleewel/WernujarlerhelkayFebairleewel/App.xaml.cs#L101-L102

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17594/index.html

@lindexi
Copy link
Contributor Author

lindexi commented Jul 23, 2024

@jeromelaban Can I ask any update here?

@MartinZikmund
Copy link
Member

We can later probably just drop the WUX namespace mention from the doc, but for now it is fine 👍

@MartinZikmund MartinZikmund merged commit 3e25434 into unoplatform:master Jul 23, 2024
15 checks passed
@lindexi lindexi deleted the patch-1 branch July 23, 2024 06:14
@lindexi
Copy link
Contributor Author

lindexi commented Jul 23, 2024

Thank you @MartinZikmund

@morning4coffe-dev
Copy link
Member

https://github.com/Mergifyio backport release/stable/5.3

Copy link
Contributor

mergify bot commented Jul 23, 2024

backport release/stable/5.3

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants