Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(brush): Don't use reflection to invoke brush updates #18899

Merged
merged 14 commits into from
Nov 27, 2024
Merged

perf(brush): Don't use reflection to invoke brush updates #18899

merged 14 commits into from
Nov 27, 2024

Conversation

jeromelaban
Copy link
Member

No description provided.

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia labels Nov 22, 2024
@jeromelaban jeromelaban mentioned this pull request Nov 22, 2024
Closed
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148209 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148210 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@github-actions github-actions bot added area/automation Categorizes an issue or PR as relevant to project automation kind/documentation labels Nov 23, 2024
@unodevops
Copy link
Contributor

⚠️⚠️ The build 148245 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148246 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148252 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148392 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@jeromelaban
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18899/index.html

@jeromelaban jeromelaban marked this pull request as ready for review November 26, 2024 19:14
dr1rrb
dr1rrb approved these changes Nov 26, 2024
View reviewed changes
src/SamplesApp/SamplesApp.Wasm/SamplesApp.Wasm.csproj Show resolved Hide resolved
src/Uno.UI/Uno.UI.netcoremobile.csproj Outdated Show resolved Hide resolved
src/Uno.UI/Uno.UI.netcoremobile.csproj Outdated Show resolved Hide resolved
src/Uno.UWP/UI/Core/WeakEventHelper.cs Outdated Show resolved Hide resolved
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18899/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148555 has failed on Uno.UI - CI.

@jeromelaban jeromelaban disabled auto-merge November 27, 2024 12:29
@jeromelaban jeromelaban merged commit 8bae473 into master Nov 27, 2024
113 of 115 checks passed
@jeromelaban jeromelaban deleted the dev/jela/brush-weak branch November 27, 2024 12:29
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.5

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024 •
edited
Loading

backport release/stable/5.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024 •
edited
Loading

backport release/stable/5.4

✅ Backports have been created

This was referenced Nov 27, 2024
Merged
Merged
jeromelaban added a commit that referenced this pull request Nov 27, 2024
@jeromelaban
Merge pull request #18940 from unoplatform/mergify/bp/release/stable/…
4192479 
…5.5/pr-18899

perf(brush): Don't use reflection to invoke brush updates (backport #18899)
jeromelaban added a commit that referenced this pull request Nov 27, 2024
@jeromelaban
Merge pull request #18941 from unoplatform/mergify/bp/release/stable/…
9734e57 
…5.4/pr-18899

perf(brush): Don't use reflection to invoke brush updates (backport #18899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia kind/documentation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeromelaban @unodevops @dr1rrb @Youssef1313