Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Don't use multicast delegates for DependencyObjectCollection.VectorChanged #18910

Merged
merged 3 commits into from
Nov 27, 2024
Merged

perf: Don't use multicast delegates for DependencyObjectCollection.VectorChanged #18910

merged 3 commits into from
Nov 27, 2024

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Nov 25, 2024 •
edited
Loading

This change avoids the high cost of multicast delegates, particularly on mono-AOT environments. We also do not need the thread safety guarantees.

Example:

image

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

backport release/stable/5.5

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18910/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18910/index.html

@jeromelaban jeromelaban marked this pull request as draft November 25, 2024 04:53
@unodevops
Copy link
Contributor

⚠️⚠️ The build 148288 has failed on Uno.UI - CI.

@jeromelaban jeromelaban force-pushed the dev/jela/overflow-perf branch 4 times, most recently from 8b15bc8 to be35b24 Compare November 25, 2024 20:54
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18910/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18910/index.html

@jeromelaban jeromelaban force-pushed the dev/jela/overflow-perf branch from be35b24 to 74ece94 Compare November 26, 2024 00:48
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18910/index.html

@jeromelaban jeromelaban force-pushed the dev/jela/overflow-perf branch from 74ece94 to ef926a2 Compare November 26, 2024 04:11
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18910/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18910/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148443 has failed on Uno.UI - CI.

@jeromelaban
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18910/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18910/index.html

@jeromelaban jeromelaban marked this pull request as ready for review November 26, 2024 21:21
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024 •
edited
Loading

backport release/stable/5.5

🛑 Command backport release/stable/5.5 cancelled because of a new backport command with different arguments

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024 •
edited
Loading

backport release/stable/5.4

🛑 Command backport release/stable/5.4 cancelled because of a new backport command with different arguments

@jeromelaban jeromelaban merged commit 5b90f03 into master Nov 27, 2024
111 of 115 checks passed
@jeromelaban jeromelaban deleted the dev/jela/overflow-perf branch November 27, 2024 00:14
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024 •
edited
Loading

backport release/stable/5.5

✅ Backports have been created

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024 •
edited
Loading

backport release/stable/5.4

✅ Backports have been created

This was referenced Nov 27, 2024
Merged
Merged
jeromelaban added a commit that referenced this pull request Nov 27, 2024
@jeromelaban
Merge pull request #18937 from unoplatform/mergify/bp/release/stable/…
730cde1 
…5.4/pr-18910

perf: Don't use multicast delegates for DependencyObjectCollection.VectorChanged (backport #18910)
jeromelaban added a commit that referenced this pull request Nov 27, 2024
@jeromelaban
Merge pull request #18936 from unoplatform/mergify/bp/release/stable/…
32a3b0c 
…5.5/pr-18910

perf: Don't use multicast delegates for DependencyObjectCollection.VectorChanged (backport #18910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@dr1rrb dr1rrb dr1rrb approved these changes

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromelaban @unodevops @carldebilly @dr1rrb @Youssef1313