-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make MenuFlyoutItem.Click working #2029
Conversation
How to make CI run again? It failed: |
how to check WHICH test is failing? It seems that fails not test in my PR, but some other.. |
/azp run |
Please be more specific... I checked source files for other platforms. And my PR can probably be extended to iOS (MenuFlyout.iOS7.iOS.cs and MenuFlyout.iOS8.iOS.cs files), but not for WASM. As I cannot in any way test iOS change on my side, should I try to make change for iOS, with hope that my UI test on azure will be sufficient? |
@pkar70 I'm taking a look at why your changes are not passing. |
Did you find cause of error? |
Not really. It's not your PR, it's the same issue from Java.exe that will probably get fixed when we'll update the CI servers. |
GitHub Issue (If applicable): #227
PR Type
What kind of change does this PR introduce?
What is the current behavior?
MenuFlyoutItem.Click is not fired.
What is the new behavior?
MenuFlyoutItem.Click is fired.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Re-created PR#1779, code change and tests in single commit.
Test is somehow based on Jerome Laban idea from 1779.
Still trying to create test, as it seems that MenuFlyout is not rendered.
Internal Issue (If applicable):