Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MenuFlyoutItem.Click working #2029

Merged
merged 16 commits into from
Nov 19, 2019
Merged

Conversation

pkar70
Copy link
Contributor

@pkar70 pkar70 commented Nov 5, 2019

GitHub Issue (If applicable): #227

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

MenuFlyoutItem.Click is not fired.

What is the new behavior?

MenuFlyoutItem.Click is fired.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Re-created PR#1779, code change and tests in single commit.
Test is somehow based on Jerome Laban idea from 1779.

Still trying to create test, as it seems that MenuFlyout is not rendered.

Internal Issue (If applicable):

@carldebilly carldebilly added the kind/enhancement New feature or request label Nov 6, 2019
@pkar70
Copy link
Contributor Author

pkar70 commented Nov 7, 2019

How to make CI run again? It failed:
Using element matching Marked("runButton").
Tapping coordinates [ 32, 76 ].
then
Query for Marked("failedTests")
But this is not my test (not test from this PR), as I don't use such names.

@pkar70
Copy link
Contributor Author

pkar70 commented Nov 7, 2019

how to check WHICH test is failing? It seems that fails not test in my PR, but some other..

@carldebilly
Copy link
Member

/azp run

@pkar70
Copy link
Contributor Author

pkar70 commented Nov 8, 2019

Please be more specific...
I mean rerun tests not on my PC, but on 'your' github/azure.

I checked source files for other platforms. And my PR can probably be extended to iOS (MenuFlyout.iOS7.iOS.cs and MenuFlyout.iOS8.iOS.cs files), but not for WASM. As I cannot in any way test iOS change on my side, should I try to make change for iOS, with hope that my UI test on azure will be sufficient?

@pkar70 pkar70 changed the title [droid] make MenuFlyoutItem.Click working make MenuFlyoutItem.Click working Nov 12, 2019
@gitpod-io
Copy link

gitpod-io bot commented Nov 15, 2019

@jeromelaban jeromelaban added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Nov 15, 2019
@jeromelaban
Copy link
Member

@pkar70 I'm taking a look at why your changes are not passing.

@pkar70
Copy link
Contributor Author

pkar70 commented Nov 19, 2019

Did you find cause of error?

@jeromelaban
Copy link
Member

Not really. It's not your PR, it's the same issue from Java.exe that will probably get fixed when we'll update the CI servers.

@mergify mergify bot merged commit fefa259 into unoplatform:master Nov 19, 2019
@pkar70 pkar70 deleted the menuflyoutitem branch November 19, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants