Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid Grid layout when using Row/Column MinWidth/MaxHeight #2128

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): Fixes #2125

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

The grid computation does not return -Infinity when measuring the following xaml:

    <Grid x:Name="TopNavGrid">
        <Grid.ColumnDefinitions>
            <ColumnDefinition Width="Auto" />
            <ColumnDefinition Width="*" MinWidth="48" />
        </Grid.ColumnDefinitions>

        <!-- Top nav list -->
        <ListView x:Name="TopNavMenuItemsHost" Grid.Column="0">
        </ListView>
    </Grid>

When the child takes the whole width.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

No release notes as this feature has not been released stable yet.

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Nov 20, 2019

@jeromelaban jeromelaban added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Nov 20, 2019
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Nov 20, 2019
@jeromelaban jeromelaban requested a review from dr1rrb November 20, 2019 03:52
@jeromelaban jeromelaban merged commit 6a6359f into master Nov 20, 2019
@jeromelaban jeromelaban deleted the dev/jela/grid-nan branch November 20, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wasm] Grid and ListView invalid measure
2 participants