-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TransformGroup #2520
Merged
Merged
Fix TransformGroup #2520
+515
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/automation
Categorizes an issue or PR as relevant to project automation
kind/documentation
labels
Jan 22, 2020
dr1rrb
added
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/ios 🍎
Categorizes an issue or PR as relevant to the iOS platform
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
ready-to-merge
Automatically merge the PR once all '.mergify.yml' policies are met
labels
Jan 22, 2020
davidjohnoliver
approved these changes
Jan 22, 2020
carldebilly
approved these changes
Jan 22, 2020
dr1rrb
removed
the
ready-to-merge
Automatically merge the PR once all '.mergify.yml' policies are met
label
Jan 22, 2020
The build 11772 found UI Test snapshots differences.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/automation
Categorizes an issue or PR as relevant to project automation
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/ios 🍎
Categorizes an issue or PR as relevant to the iOS platform
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: fixes #2513
Bug fix
TransformGroup
are not workingWhat is the current behavior?
When the
Children
collection ofTransfromGroup
is updated, it invokes the baseTransform.NotifyChanged()
but this won't update theMatrixCore
.What is the new behavior?
MatrixCore
is now updated by theNotifyChanged()
.PR Checklist
Screenshots Compare Test Run
results.