Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TransformGroup #2520

Merged
merged 5 commits into from
Jan 22, 2020
Merged

Fix TransformGroup #2520

merged 5 commits into from
Jan 22, 2020

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Jan 22, 2020

GitHub Issue: fixes #2513

Bug fix

TransformGroup are not working

What is the current behavior?

When the Children collection of TransfromGroup is updated, it invokes the base Transform.NotifyChanged() but this won't update the MatrixCore.

What is the new behavior?

MatrixCore is now updated by the NotifyChanged().

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@gitpod-io
Copy link

gitpod-io bot commented Jan 22, 2020

@github-actions github-actions bot added area/automation Categorizes an issue or PR as relevant to project automation kind/documentation labels Jan 22, 2020
@dr1rrb dr1rrb self-assigned this Jan 22, 2020
@dr1rrb dr1rrb added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met labels Jan 22, 2020
@dr1rrb dr1rrb removed the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Jan 22, 2020
@nventive-devops
Copy link
Contributor

The build 11772 found UI Test snapshots differences.

  • android-28: 8 changed over 256

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • PopupWithOverlay_After
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestManipulation_Result
    • TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners
    • ToggleSwitch_TemplateReuseTest_UITests_Shared_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_TemplateReuse
    • When_InListViewWithoutItemClick_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests
  • android-28-Snap: 13 changed over 653

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
    • Button_ComboBox_Simple_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ComboBox_Simple
    • ImageBrushTestControl_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
    • ListView_ListViewResizableText_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListViewResizableText
    • ListView_ListView_WithScrollViewer_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_WithScrollViewer
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_UndefinedHeightListView_SamplesApp_Windows_UI_Xaml_Controls_ListView_UndefinedHeightListView
    • TextBlockControl_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
    • TextBlockControl_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
    • Transform_TransformToVisual_Translate2d_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_TransformToVisual_Translate2d
  • ios: 7 changed over 115

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DatePickerFlyout_Unloaded_UITests_Shared_Windows_UI_Xaml_Controls_DatePicker_DatePicker_SampleContent
    • Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
  • ios-Snap: 6 changed over 644

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_ComboBox_Simple_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ComboBox_Simple
    • Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • ContentControlTestsControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Default_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
    • MediaPlayerElement_Using__3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
  • wasm: 2 changed over 657

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Windows_UI_Xaml_Media.Animation.SequentialAnimationsPage
    • Uno.UI.Samples.UITests.Image.Image_Margin
  • wasm-automated: 5 changed over 312

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
    • PopupWithOverlay_During
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners
    • When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer

@dr1rrb dr1rrb merged commit 9952561 into master Jan 22, 2020
@dr1rrb dr1rrb deleted the dev/dr/TrGroup branch January 22, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Please support for TransformGroup on iOS
4 participants