Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm] Fix ComboBox should not stretch to the full window width #2745

Merged
merged 1 commit into from
Mar 5, 2020
Merged

[Wasm] Fix ComboBox should not stretch to the full window width #2745

merged 1 commit into from
Mar 5, 2020

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): Fixes #2680

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

A ComboBox with HorizontalAlignment set to Stretch stretches the content of its drop down to the width of the screen.

What is the new behavior?

The ComboBox dropdown does not stretch.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • [x ] Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2020 •
edited
Loading

@github-actions github-actions bot added area/automation Categorizes an issue or PR as relevant to project automation platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform kind/documentation labels Mar 4, 2020
@jeromelaban jeromelaban force-pushed the dev/jela/combobox-width branch from 52b99af to bc56b05 Compare March 4, 2020 19:43
@nventive-devops
Copy link
Contributor

The build 12786 found UI Test snapshots differences.

  • android-28: 7 changed over 316

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • PopupWithOverlay_After
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Simple_ContentDialog_01_PrimaryCommand_UITests_Shared_Windows_UI_Xaml_Controls_ContentDialogTests_ContentDialog_Simple
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • TestManipulation_Result
    • ToggleSwitch_TemplateReuseTest_UITests_Shared_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_TemplateReuse

  • android-28-Snap: 9 changed over 680

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_VisibleBounds
    • Default_Uno_UI_Samples_UITests_Image_Image_UseTargetSize_Uno_UI_Samples_UITests_Image_Image_UseTargetSize
    • Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100
    • ListView_ListView_WithScrollViewer_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_WithScrollViewer
    • Transform_TransformToVisual_Translate2d_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_TransformToVisual_Translate2d
    • TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll
    • WebView_WebView_NavigateToString_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToString

  • ios: 1 changed over 166

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox

  • ios-Snap: 3 changed over 670

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BitmapIcon_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic
    • Default_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
    • Image_UniformToFill100x100_Uno_UI_Samples_UITests_ImageTestsControl_UniformToFill100x100

  • wasm: 2 changed over 680

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • initial_state
    • Uno.UI.Samples.Content.UITests.Transform.Image_With_RotateTransform

  • wasm-automated: 6 changed over 353

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Draw_polygon_PolygonPage_-_ChangeShape
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
    • PopupWithOverlay_During
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Simple_ContentDialog_01_Secondary_Secondary_Button

@jeromelaban jeromelaban merged commit 497cdc6 into master Mar 5, 2020
@jeromelaban jeromelaban deleted the dev/jela/combobox-width branch March 5, 2020 13:20
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/beta/2.1

@mergify mergify bot mentioned this pull request Mar 11, 2020
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2020

Command backport release/beta/2.1: success

Backports have been created

jeromelaban added a commit that referenced this pull request Mar 11, 2020
@jeromelaban
Merge pull request #2783 from unoplatform/mergify/bp/release/beta/2.1…
0c6fe07 
…/pr-2745

[Wasm] Fix ComboBox should not stretch to the full window width (bp #2745)
@agneszitte agneszitte mentioned this pull request Jun 12, 2020
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventive-devops nventive-devops nventive-devops left review comments

@agneszitte agneszitte agneszitte approved these changes

@davidjohnoliver davidjohnoliver davidjohnoliver approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WASM] Combobox dropdown width incorrect with Stretch
4 participants
@jeromelaban @nventive-devops @davidjohnoliver @agneszitte