-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix ProgressRing fails to display (bp #2764) #2794
Merged
jeromelaban
merged 6 commits into
release/beta/2.1
from
mergify/bp/release/beta/2.1/pr-2764
Mar 12, 2020
Merged
[Android] Fix ProgressRing fails to display (bp #2764) #2794
jeromelaban
merged 6 commits into
release/beta/2.1
from
mergify/bp/release/beta/2.1/pr-2764
Mar 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProgressRing inside a StackPanel was failing to display because its desired size wasn't set. Fix this by introducing a flag to distinguish between managed views that have their own Layouter, and those that don't (like ProgressRing). (cherry picked from commit 121a5fd)
Not needed with new project system. (cherry picked from commit 957386f)
(cherry picked from commit 6a5ab6e)
(cherry picked from commit 237f9ed)
(cherry picked from commit ad6700a)
Width value isn't guaranteed across all platforms in this scenario. (cherry picked from commit cc3f6ce)
7 tasks
github-actions
bot
added
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/ios 🍎
Categorizes an issue or PR as relevant to the iOS platform
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
kind/documentation
labels
Mar 11, 2020
The build 12994 found UI Test snapshots differences.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform/android 🤖
Categorizes an issue or PR as relevant to the Android platform
platform/ios 🍎
Categorizes an issue or PR as relevant to the iOS platform
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #2764 done by Mergify
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR@Mergifyio backports <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/