-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Include Margin when measuring from LayoutManager #2800
Conversation
The LayoutManager is used when AreDimensionsConstrained = true for a particular view, which can be set manually as an optimization if it's known that a view's size will never change. It wasn't taking the Margin into account when measuring the view, which was causing errors after layouting changes.
|
||
protected override Size MeasureOverride(Size availableSize) | ||
{ | ||
var height = double.IsPositiveInfinity(availableSize.Height) ? 0 : availableSize.Height; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wut
The build 13034 found UI Test snapshots differences.
|
@Mergifyio backport release/beta/2.1 |
Command
|
@Mergifyio backport release/beta/2.1 |
Command
|
…/pr-2800 [Android] Include Margin when measuring from LayoutManager (bp #2800)
The LayoutManager is used when
AreDimensionsConstrained = true
for a particular view, which can be set manually as an optimization if it's known that a view's size will never change. It wasn't taking the Margin into account when measuring the view, which was causing errors after layouting changes.GitHub Issue (If applicable): fixes #2761
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):