Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (macOS) Add support for PasswordBox #3034

Merged
merged 11 commits into from
May 4, 2020

Conversation

ajpinedam
Copy link
Contributor

GitHub Issue (If applicable): #
closes: #3005

PR Type

  • Feature

What is the current behavior?

PasswordBox is not supported on macOS

What is the new behavior?

macOS does support PasswordBox

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Apr 22, 2020

src/Uno.UI/UI/Xaml/Controls/PasswordBox/PasswordBox.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/PasswordBox/PasswordBox.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/PasswordBox/PasswordBox.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.cs Outdated Show resolved Hide resolved
@ajpinedam
Copy link
Contributor Author

macOS_Login

@jeromelaban
Copy link
Member

@ajpinedam looks like the build failed.

@ajpinedam
Copy link
Contributor Author

ajpinedam commented Apr 27, 2020

The build is failing with this error, what is it about?

##[error]EXEC(0,0): Error : Removed method Windows.UI.Xaml.DependencyProperty Windows.UI.Xaml.Controls.PasswordBox.get_IsPasswordRevealButtonEnabledProperty() not found in ignore set.

##[error]EXEC(0,0): Error : Removed method System.Void Windows.UI.Xaml.Controls.TextBox..ctor(System.Boolean isPassword) not found in ignore set.

##[error]EXEC(0,0): Error : Removed property Windows.UI.Xaml.DependencyProperty Windows.UI.Xaml.Controls.PasswordBox::IsPasswordRevealButtonEnabledProperty() not found in ignore set.

@jeromelaban / @davidjohnoliver

InitializeVisualStates();
this.RegisterParentChangedCallback(this, OnParentChanged);
}

private void OnParentChanged(object instance, object key, DependencyObjectParentChangedEventArgs args) => UpdateFontPartial();

protected TextBox(bool isPassword)
Copy link
Member

@jeromelaban jeromelaban Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this one is not used, you'll need to add System.Void Windows.UI.Xaml.Controls.TextBox..ctor(System.Boolean isPassword) to the DiffIgnore file. There's a block missing since the update to 2.2.0, carl's PR will add it. Once the block is there, you can add your method.

@ajpinedam ajpinedam force-pushed the dev/anpi/passwordBox.macOS branch from 9804bf3 to 9eca43a Compare May 4, 2020 02:28
@jeromelaban jeromelaban merged commit 4332fdc into unoplatform:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Support for PasswordBox
3 participants