-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (macOS) Add support for PasswordBox #3034
feat: (macOS) Add support for PasswordBox #3034
Conversation
src/Uno.UI/Generated/3.0.0.0/Windows.UI.Xaml.Controls/PasswordBox.cs
Outdated
Show resolved
Hide resolved
@ajpinedam looks like the build failed. |
The build is failing with this error, what is it about?
|
InitializeVisualStates(); | ||
this.RegisterParentChangedCallback(this, OnParentChanged); | ||
} | ||
|
||
private void OnParentChanged(object instance, object key, DependencyObjectParentChangedEventArgs args) => UpdateFontPartial(); | ||
|
||
protected TextBox(bool isPassword) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this one is not used, you'll need to add System.Void Windows.UI.Xaml.Controls.TextBox..ctor(System.Boolean isPassword)
to the DiffIgnore file. There's a block missing since the update to 2.2.0, carl's PR will add it. Once the block is there, you can add your method.
Co-Authored-By: Jérôme Laban <jlaban@gmail.com>
9804bf3
to
9eca43a
Compare
GitHub Issue (If applicable): #
closes: #3005
PR Type
What is the current behavior?
PasswordBox is not supported on macOS
What is the new behavior?
macOS does support PasswordBox
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):