fix: TabView does not render item content with bindings #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
reviewed
Jan 13, 2021
jeromelaban
approved these changes
Jan 15, 2021
MartinZikmund
added
the
ready-to-merge
MartinZikmund
force-pushed
the
dev/mazi/tabview-databind
branch
2 times, most recently
from
dcda9f1 to
75a3762
Compare
davidjohnoliver
approved these changes
Jan 18, 2021
MartinZikmund
removed
the
ready-to-merge
- Test page to verify tab content changes when switching between data-bound items
- Workaround for unoplatform#4894 in TabView - sets the ContentPresenter's DataContext so that it matches the DataContext of the TabViewItem.
- Fixes issues unoplatform#4899 and unoplatform#4907 - The applied Uno specific workaround is reported as issue unoplatform#4925
MartinZikmund
force-pushed
the
dev/mazi/tabview-databind
branch
from
eb4a2ce to
ef8e6bc
Compare
MartinZikmund
added
the
ready-to-merge
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes #4895, fixes #4899, fixes #4875, fixes #4907
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Content is not rendered.
What is the new behavior?
Content is rendered.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.