Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Selector.SelectionChanged is raised twice on updated selection #547

Merged
merged 4 commits into from
Feb 1, 2019

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Jan 31, 2019

GitHub Issue (If applicable): #527

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When an item is selected in Single selection mode, the Selector.SelectionChanged is raised twice.

What is the new behavior?

  • The event is now raised only once.
  • Fixed NRE when clearing ListViewBase.ItemsSource

PR Checklist

Please check if your PR fulfills the following requirements:

@jeromelaban jeromelaban changed the title Fix for Selector.SelectionChanged is raised twice on updated selection Fix for Selector.SelectionChanged is raised twice on updated selection Jan 31, 2019
@jeromelaban jeromelaban requested review from dr1rrb and carldebilly and removed request for dr1rrb January 31, 2019 20:42
@jeromelaban jeromelaban force-pushed the dev/jela/double-selectionchanged branch from ddf2886 to 5992dea Compare February 1, 2019 03:06
@jeromelaban jeromelaban force-pushed the dev/jela/double-selectionchanged branch from 6a460f2 to d65337d Compare February 1, 2019 16:14
@jeromelaban jeromelaban merged commit afb5416 into master Feb 1, 2019
@jeromelaban jeromelaban deleted the dev/jela/double-selectionchanged branch February 1, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants