Support for AutoSuggestBox.QueryIcon #5629

MartinZikmund · 2021-03-31T10:04:10Z

GitHub Issue (If applicable): fixes #5545

PR Type

What kind of change does this PR introduce?

Not supported

Supported

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Internal Issue (If applicable):

gitpod-io · 2021-03-31T10:04:13Z

src/Uno.UI/UI/Xaml/Controls/AutoSuggestBox/AutoSuggestBox.cs

...SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/AutoSuggestBoxTests/MeasuredBitmapIcon.cs

...amplesApp/UITests.Shared/Windows_UI_Xaml_Controls/BitmapIconTests/BitmapIcon_Generic.xaml.cs

src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/FontIcon/FontIconControlTest.xaml.cs

src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Shapes/PathTestsControl/PathIcon.xaml.cs

MartinZikmund added 2 commits March 31, 2021 12:00

test: AutoSuggestBox and BitmapIcon samples

0d7ff55

fix: AutoSuggestBox.QueryIcon does not work

1486945

- Fixes unoplatform#5545

MartinZikmund requested a review from a team March 31, 2021 10:04

jeromelaban approved these changes Mar 31, 2021

View reviewed changes

src/Uno.UI/UI/Xaml/Controls/AutoSuggestBox/AutoSuggestBox.cs Outdated Show resolved Hide resolved

MartinZikmund self-assigned this Mar 31, 2021

carldebilly approved these changes Mar 31, 2021

View reviewed changes

chore: Address comments

8804029

MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Mar 31, 2021

mergify bot merged commit 36bc73b into unoplatform:master Apr 1, 2021