Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only streams should not throw on Flush, adjust NotImplemented on Pickers #5768

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Apr 16, 2021

GitHub Issue (If applicable): fixes #5751, fixes #5766

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • Some read-only streams in Storage APIs throw on Flush.
  • Analyzers report file pickers as not implemented even though they are

What is the new behavior?

  • Some of the read-only streams in Storage APIs no longer throw on Flush calls to match UWP behavior.
  • Adjust NotImplemented attributes on file pickers

PR Checklist

Please check if your PR fulfills the following requirements:

- Currently picker-related types show up as not implemented in Uno (unoplatform#5766)
- Fixes unoplatform#5751 by making Flush a no-op for some of the Storage read-only streams
@MartinZikmund MartinZikmund requested a review from a team April 16, 2021 10:35
@gitpod-io
Copy link

gitpod-io bot commented Apr 16, 2021

@MartinZikmund MartinZikmund self-assigned this Apr 16, 2021
@MartinZikmund MartinZikmund changed the title Read-only streams should not throw on Flush Read-only streams should not throw on Flush, adjust NotImplemented on Pickers Apr 16, 2021
@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Apr 19, 2021
@mergify mergify bot merged commit f8496a7 into unoplatform:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
3 participants