Improve source generation performance #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/source-gen-update
branch
4 times, most recently
from
2f3741d to
bbd508a
Compare
- Remove unused net461 and Xamarin targets previously added for Roslyn compatibility - Update to net461 for test assemblies to enable netstandard2.0 compatibility - Update to msbuild sdk extras 1.6.68 to restore proper build parallelism
This target won't be useable as the Play Store will reject it.
Update to 15.9.7 targeting newer CI containers.
jeromelaban
force-pushed
the
dev/jela/source-gen-update
branch
from
220274a to
96ad2ca
Compare
This tool is deprecated as all the API is imported. Will be replaced by nuget package diffing tool.
jeromelaban
force-pushed
the
dev/jela/source-gen-update
branch
from
51319b5 to
a0d0ff6
Compare
MatFillion
reviewed
Mar 4, 2019
MatFillion
reviewed
Mar 4, 2019
MatFillion
reviewed
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes #139
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Uno.UI solution build time is longer than it should be, cross targeted projects build are serialized.
What is the new behavior?
net461for test projects so the theUno.Xamlproject can be referenced properlyDirectory.Build.targetsfile so it's easier to change all versions at once.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):