-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for ThemeShadow
#6362
Initial support for ThemeShadow
#6362
Conversation
85b8ef5
to
4168514
Compare
34a2052
to
449f2fc
Compare
449f2fc
to
5822668
Compare
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Outdated
Show resolved
Hide resolved
e020b17
to
6f42155
Compare
6f42155
to
144efee
Compare
7660b9a
to
0088b34
Compare
Happy New Year! Curious, if this PR is merged: will ThemeShadow then be fully supported
|
@DierkDroth Support for |
Thanks for your feedback @MartinZikmund
|
@DierkDroth oh, that's actually good news, as |
f8e834a
to
a38f33b
Compare
@MartinZikmund is ThemeShadow still being worked on? Is there an ETA available? Also: when working it could be assigned e.g. to Border.Shadow and Border.Translation could be set to define the elevation, correct? |
cb9318b
to
77454ad
Compare
@MartinZikmund FYI I took the plunge and applied ElevatedView on WASM in theme XAML and code whereever shadow was missing. So, ThemeShadow on WASM no longer is of priority to me. Nevertheless, it would be great to see ThemeShadow support in UNO... BTW I also tried to use ElevatedView on WindowsAppSDK (using latest Uno.WinUI bits) - since I actually find it nicer than the Windows default - but experienced a funny problem: after a few seconds and when moving the mouse around the shadow effect from ElevatedView vanishes and I 'only' saw the default shadow effect from WindowsAppSDK. Not sure if I did something wrong or if there really is an issue with ElevatedView on Windows... |
42a8e91
to
3c74983
Compare
3c74983
to
903f3e3
Compare
67b26b5
to
47bf676
Compare
@jeromelaban the merge is blocked by the conventional commits validation, can you force merge? |
GitHub Issue (If applicable): part of #11115
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ThemeShadow
not supportedWhat is the new behavior?
Basic support for WASM and Android
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.