-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Selector): firing order of data-bound dp & event #6371
fix(Selector): firing order of data-bound dp & event #6371
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍 . Just check the unit tests that fail now, it is possible they depended on the old behavior
756a6e4
to
6b34c40
Compare
This comment has been minimized.
This comment has been minimized.
Could you add a test in Uno.UI.RuntimeTests corresponding to the scenario in the issue? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The build 30221 found UI Test snapshots differences: Details
|
This is the original comment for this issue:
It feels like a UI tests is needed now to validate this, a runtime tests would also enhance the coverage significantly. |
6b34c40
to
a398c1c
Compare
The build 30400 found UI Test snapshots differences: Details
|
The build 30400 found UI Test snapshots differences: Details
|
The build 30400 found UI Test snapshots differences: Details
|
a398c1c
to
a4ccc0a
Compare
SelectionChanged event were being called before SelectedItem binding could be updated.
a4ccc0a
to
480b30c
Compare
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ListViewBase.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The build 30920 found UI Test snapshots differences: Details
|
The build 30920 found UI Test snapshots differences: Details
|
The build 30912 found UI Test snapshots differences: Details
|
The build 30912 found UI Test snapshots differences: Details
|
@MartinZikmund Is this PR ready to be merged? |
@Xiaoy312 yes, good to go |
GitHub Issue (If applicable): fixes #5792, fixes #6496
PR Type
What kind of change does this PR introduce?
What is the current behavior?
SelectionChanged event were being fired before SelectedItem binding could be updated.
What is the new behavior?
SelectedItem binding will be updated before the SelectionChanged event is fired.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information