Paths were broken in Wasm #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
The PR #698 introduced a bug on Wasm where "Data Path" were not properly translated to
DataGeometry(a type used to hold a path data instead on parsing it).What is the current behavior?
The parsing of the Data Path was not working properly on Wasm.
What is the new behavior?
Old behavior has been restored, but only on Wasm.
PR Checklist
Please check if your PR fulfills the following requirements:
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)[ ] Updated the Release Notes[ ] Associated with an issue (GitHub or internal)Other information
Internal Issue (If applicable):