chore: Adjust Uno.Core dependencies #7461
Merged
+18,230
−1,346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
force-pushed
the
dev/jela/uno-core-remove-2
branch
from
aedd3bb
to
0d5b23d
Compare
Youssef1313
reviewed
Nov 11, 2021
| private readonly object _gate = new object(); | ||
|
|
||
| private bool _disposed; | ||
| private List<IDisposable?> _disposables; |
There was a problem hiding this comment.
On Add, we throw on nulls. So this can be non-nullable I believe?
|
|
||
| lock (_gate) | ||
| { | ||
| Array.Copy(_disposables.Where(d => d != null).ToArray(), 0, array, arrayIndex, array.Length - arrayIndex); |
There was a problem hiding this comment.
Most likely the Where part won't be needed if my previous comment is correct.
|
|
||
| lock (_gate) | ||
| { | ||
| res = _disposables.Where(d => d != null).ToList(); |
There was a problem hiding this comment.
Same about null check here.
| Action = action; | ||
| } | ||
|
|
||
| public Action Action { get; private set; } |
There was a problem hiding this comment.
nit: Setter not actually needed
Suggested change
| public Action Action { get; private set; } | |
| public Action Action { get; } |
|
|
||
| public static string JoinBy(this IEnumerable<string> items, string joinBy) | ||
| { | ||
| return string.Join(joinBy, items.ToArray()); |
There was a problem hiding this comment.
string.Join already has an overload that accepts IEnumerable<string>, why to call .ToArray?
| /// <param name="items">The items to add.</param> | ||
| public static void AddRange<T>(this ICollection<T> collection, IEnumerable<T> items) | ||
| { | ||
| items.ForEach(collection.Add); |
There was a problem hiding this comment.
I think this may perform better if I understand dotnet/roslyn#5835 correctly. Can help to see the decompiled source for both.
Suggested change
| items.ForEach(collection.Add); | |
| items.ForEach(item => collection.Add(item)); |
jeromelaban
force-pushed
the
dev/jela/uno-core-remove-2
branch
3 times, most recently
from
45e4eda
to
6b1f715
Compare
jeromelaban
force-pushed
the
dev/jela/uno-core-remove-2
branch
from
c93be94
to
7badd81
Compare
BREAKING CHANGE: - Removal of Uno.Extensions.ObservableCollectionUpdateResultsExtensions - Removal of UIAsyncOperation.CompletionSource - Changed type of ApiInformation.NotImplementedLogLevel to Uno.Foundation.Logging.LogLevel
…ons.Logging.Singleton
|
The build 36380 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):