Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AutoSuggestBox should keep focus when popup is opened #7736

Merged

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #7675

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

AutoSuggestBox loses focus when its popup opens because IsLightDismissEnabled defaults to true on Uno instead of false as in UWP (and IsLightDismissEnabled popups may capture focus when opened)

What is the new behavior?

  • Popup.IsLightDismissEnabled is now false by default to match UWP
  • Added FeatureConfiguration.Popup.EnableLightDismissByDefault that allows turning the legacy behavior back on where needed
  • Added tests to cover the default, and the text change behavior of AutoSuggestBox

PR Checklist

Please check if your PR fulfills the following requirements:

@MartinZikmund MartinZikmund requested a review from a team January 4, 2022 09:13
@MartinZikmund MartinZikmund self-assigned this Jan 4, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 4, 2022

@MartinZikmund MartinZikmund force-pushed the dev/mazi/autosuggestbox-focus branch 10 times, most recently from 5810514 to 8301a1e Compare January 9, 2022 12:07
@MartinZikmund MartinZikmund force-pushed the dev/mazi/autosuggestbox-focus branch from 1bc22f6 to 96449ab Compare January 18, 2022 08:55
@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Jan 18, 2022
@mergify mergify bot merged commit 83369e3 into unoplatform:master Jan 18, 2022
@MartinZikmund MartinZikmund deleted the dev/mazi/autosuggestbox-focus branch January 18, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Skia.Wpf - Skia.Gtk] AutoSuggestBox doesn't work right
5 participants