-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AutoSuggestBox
should keep focus when popup is opened
#7736
Merged
mergify
merged 6 commits into
unoplatform:master
from
MartinZikmund:dev/mazi/autosuggestbox-focus
Jan 18, 2022
Merged
fix: AutoSuggestBox
should keep focus when popup is opened
#7736
mergify
merged 6 commits into
unoplatform:master
from
MartinZikmund:dev/mazi/autosuggestbox-focus
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Jan 4, 2022
Youssef1313
reviewed
Jan 4, 2022
Youssef1313
reviewed
Jan 4, 2022
Youssef1313
reviewed
Jan 4, 2022
Youssef1313
reviewed
Jan 4, 2022
Youssef1313
reviewed
Jan 4, 2022
Youssef1313
reviewed
Jan 4, 2022
jeromelaban
reviewed
Jan 4, 2022
MartinZikmund
force-pushed
the
dev/mazi/autosuggestbox-focus
branch
10 times, most recently
from
January 9, 2022 12:07
5810514
to
8301a1e
Compare
jeromelaban
approved these changes
Jan 11, 2022
ajpinedam
approved these changes
Jan 18, 2022
MartinZikmund
force-pushed
the
dev/mazi/autosuggestbox-focus
branch
from
January 18, 2022 08:55
1bc22f6
to
96449ab
Compare
MartinZikmund
added
the
ready-to-merge
Automatically merge the PR once all '.mergify.yml' policies are met
label
Jan 18, 2022
davidjohnoliver
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #7675
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AutoSuggestBox
loses focus when its popup opens becauseIsLightDismissEnabled
defaults totrue
on Uno instead offalse
as in UWP (andIsLightDismissEnabled
popups may capture focus when opened)What is the new behavior?
Popup.IsLightDismissEnabled
is nowfalse
by default to match UWPFeatureConfiguration.Popup.EnableLightDismissByDefault
that allows turning the legacy behavior back on where neededAutoSuggestBox
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.