Improvements in EmbedIO.Net.Internal namespace; also, component collections are back. #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not hold a reference to the context, only to actually used data * Manage content length vs. chunked consistently * Manage keep-alive consistently * Do not create another StringBuilder to append a Set-Cookie header * Remove unused property ForceCloseChunked * Avoid StringBuilder.AppendFormat for performance * Methodize code that ensures that a header-related property can be set * Use HttpDate.Format to format the Date header
rdeago
added
enhancement
v3.x
dependencies
rdeago
changed the title
rdeago
changed the title
|
This pull request fixes 4 alerts when merging cf1c91c into ea4cd3d - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging aa10086 into ea4cd3d - view on LGTM.com fixed alerts:
|
Got it. |
|
This pull request fixes 4 alerts when merging c069eee into ea4cd3d - view on LGTM.com fixed alerts:
|
geoperez
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for version 4.0, I made some changes to internal classes.
No breaking changes here; this PR could probably be backported to version 3 if desired.
EDIT: I also added back component collections, so they can be safely removed from SWAN 3.0.
EDIT: Added JSON request deserializer with specified property name casing.