Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit native events on form controls #1216

Closed
wants to merge 3 commits into from
Closed

Conversation

epr3
Copy link
Collaborator

@epr3 epr3 commented Aug 11, 2024

Closes #1209.

Hello,

This PR emits native form events on all form controls whenever the checked or modelValue changes on the respective form element.

Any feedback is appreciated! 🚀

Copy link

Deploying radix-vue with  Cloudflare Pages  Cloudflare Pages

Latest commit: d8c4955
Status: ✅  Deploy successful!
Preview URL: https://a334a7b9.radix-vue.pages.dev
Branch Preview URL: https://1209-bugfix-checkbox.radix-vue.pages.dev

View logs

@zernonia
Copy link
Member

I'm kinda holding back with this changes because these hidden input will be replaced with VisuallyHiddenInput in v2 😬

@epr3
Copy link
Collaborator Author

epr3 commented Aug 15, 2024

@zernonia Should I implement this feature based off the v2 branch?

@zernonia
Copy link
Member

Yeah I think better to have this in v2

@epr3 epr3 closed this Aug 22, 2024
@epr3 epr3 deleted the 1209-bugfix-checkbox branch August 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: checkbox does not dispatch "input" event, like native checkbox
2 participants