Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DismissableLayer): branch could be null #1256

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

rankjie
Copy link
Contributor

@rankjie rankjie commented Aug 28, 2024

Received error report in production via Sentry:

TypeError
Cannot read properties of null (reading 'contains')
at radix-vue/dist/index.js in m at line 2205:18
-> (S) => S.contains(g.target)

It looks like my previous commits which have already been merged were also included in this PR.
Not sure how to edit them out.
Please let me know if it's not possible to pick the last commit only, I'll close this and create a new PR. Sorry about that!

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @rankjie 🚀

@zernonia zernonia merged commit 0cf2c06 into unovue:main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants