fix(Combobox): stop event propagation on enter #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my attempt of fixing the bug described in #1278
Important: the test case here is a false-positive: when I remove theevent.stopPropagation()line, it still passes. I'm not surer why - I don't have too much experience with vitest and if event bubbling actually happens in the test environment?Since we're not using a real browser, the enter event bubbling up to form is not causing a form submit in tests. So, instead of testing for the handleSubmit not to be called, I updated the test to check if the enter event bubbled up to the form.
With this change, removing the
event.stopPropagation()call will cause the test to fail.