Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: root node for RovingFocusItem when shadowRoot #1314

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: root node for RovingFocusItem when shadowRoot #1314

merged 2 commits into from
Sep 25, 2024

Conversation

cain
Copy link
Contributor

@cain cain commented Sep 23, 2024

This PR fixes RovingFocusItem getting the rootNode when using radix-vue in a shadow dom.

Fixes: #1003

Thanks @sunnylost for the detailed fix

@zernonia
Copy link
Member

Thanks for the PR @cain 😁!

@zernonia zernonia merged commit fed1551 into unovue:main Sep 25, 2024
3 checks passed
@zernonia
Copy link
Member

Adding @sunnylost as co-author too! 😁 Thanks for your valuable input!

@cain cain deleted the roving-focus-item-root-node-shadow branch September 25, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Web component radio group arrow key bug
2 participants
@cain @zernonia