Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treeshaking of some components #584

Merged
merged 2 commits into from
Jan 10, 2024
+425 −88
Merged

fix: treeshaking of some components #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b833c
fix: treeshaking of some components
94726 Jan 4, 2024
c40f0a4
fix: type-check
94726 Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .histoire/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
"postcss": "^8.4.31",
"tailwindcss": "^3.3.3",
"vite": "^4.3.9",
"vue": "^3.3.8"
"vue": "^3.4.5"
}
}
7 changes: 4 additions & 3 deletions packages/radix-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"url": "https://github.com/radix-vue/radix-vue/issues"
},
"keywords": [],
"sideEffects": false,
"exports": {
".": {
"require": "./dist/index.umd.cjs",
Expand Down Expand Up @@ -65,7 +66,7 @@
"@vitejs/plugin-vue": "^4.4.0",
"@vitejs/plugin-vue-jsx": "^3.0.2",
"@vitest/coverage-istanbul": "^0.33.0",
"@vue/shared": "^3.3.8",
"@vue/shared": "^3.4.6",
"@vue/test-utils": "^2.4.1",
"@vue/tsconfig": "^0.4.0",
"@vueuse/components": "^10.5.0",
Expand All @@ -81,8 +82,8 @@
"vitest": "^0.34.6",
"vitest-axe": "0.1.0",
"vitest-canvas-mock": "^0.3.3",
"vue": "^3.3.8",
"vue": "^3.4.6",
"vue-component-type-helpers": "^1.8.22",
"vue-tsc": "^1.8.19"
"vue-tsc": "1.8.27"
}
}
4 changes: 2 additions & 2 deletions packages/radix-vue/src/Combobox/ComboboxRoot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const props = withDefaults(defineProps<ComboboxRootProps<T>>(), {
})
const emit = defineEmits<ComboboxRootEmits<T>>()

const { multiple, disabled, name, dir: propDir } = toRefs(props)
const { multiple, disabled, dir: propDir } = toRefs(props)
const dir = useDirection(propDir)

const searchTerm = useVModel(props, 'searchTerm', emit, {
Expand Down Expand Up @@ -244,7 +244,7 @@ provideComboboxRootContext({
:value="modelValue"
/>

<VisuallyHiddenInput v-if="isFormControl && name" :name="name" :value="modelValue" />
<VisuallyHiddenInput v-if="isFormControl && props.name" :name="props.name" :value="modelValue" />
</Primitive>
</PopperRoot>
</template>
2 changes: 1 addition & 1 deletion packages/radix-vue/src/PinInput/story/_PinInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ const value = ref<string[]>([])
<template>
<Label for="otp">Test label</Label>
<PinInputRoot
v-bind="{ ...props, ...useEmitAsProps(emits) }"
v-model="value"
class="flex gap-2 items-center"
v-bind="{ ...props, ...useEmitAsProps(emits) }"
>
<PinInputInput
v-for="(id, index) in 5"
Expand Down
Loading
Loading