[Bug]: Popover max-height need to be limited by available height

[hrynevychroman]

Environment

Main Website

Link to minimal reproduction

https://www.shadcn-vue.com/examples/cards

Steps to reproduce

Just open Year Select on left card

Describe the bug

Select don't limit by available height 🙂

Expected behavior

Need to add height, or max-height (think that max-height is better) to popover element, so scroll will be shown

Conext & Screenshots (if applicable)

No response

[hrynevychroman]

I will make PR to fix this issue 🙂

[sadeghbarati]

Great, Thanks 🙌

[hrynevychroman]

@sadeghbarati sorry for tagging you, but I don't familiar with GitHub (working on GitLab mostly), how can I push new branch with PR, I don't have permissions( Maybe you can give me some guide how to make PR rightly)

[sadeghbarati]

Fork the repository -> go to the main page of the repository -> top-right -> left side of the start button

Now you have your own (origin) which you can push a new branch to it, without affecting (upstream) repository which also you have no permission but it's better to work on your origin even if you have permission

You can use VSCode or Git CLI or Git GUI Apps like GitHub Desktop, SourceTree, GitKraken, ...

[hrynevychroman]

@sadeghbarati Thank you! ❤️

Fork the repository -> go to the main page of the repository -> top-right -> left side of the start button

Now you have your own (origin) which you can push a new branch to it, without affecting (upstream) repository which also you have no permission but it's better to work on your origin even if you have permission

You can use VSCode or Git CLI or Git GUI Apps like GitHub Desktop, SourceTree, GitKraken, ...